Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

parsefrom(Bytebuf) is unsafe #3

@cbornet

Description

@cbornet

Very nice initiative ! I'll have a look at how to integrate into gRPC and use it in Pulsar-gRPC

Since parseFrom does zero-copy, I understand that the Bytebuf passed as argument must not be released as long as the deserialized object may be used. So the name of the operation should probably reflect that? For instance, the classic protobuf lib uses the name unsafeWrap (in UnsafeByteOperations). WDYT ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions