From efe354dd61e8ac7e93320ec3bcd4b55a79726f96 Mon Sep 17 00:00:00 2001 From: sovanken Date: Fri, 14 Aug 2026 11:04:54 +0700 Subject: [PATCH] Correct the stale flutter_lints comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dependabot widened the constraint to ">=5.0.0 <7.0.0" (4f89c3d), but the comment above it still claimed "we pin to 5.x". Anyone reading it would conclude the constraint had drifted from its intent and re-pin it. The range is actually the right answer, so document why rather than reverting: Dart 3.6 contributors resolve 5.x and can still run `pub get`, newer SDKs resolve 6.x, and CI covers both — the pinned 3.27 job exercises 5.x, the stable matrix exercises 6.x. Verified with a fresh resolve to flutter_lints 6.0.0 / lints 6.1.0: analyze reports no issues and all 40 tests pass. Also warn against narrowing to ^6.0.0, which breaks `pub get` on the declared minimum and had to be reverted once already in 5ddbd67. Co-Authored-By: Claude Opus 5 (1M context) --- pubspec.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index fbd79a4d..010de993 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -47,8 +47,14 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - # flutter_lints 6.x requires Dart 3.8+; we pin to 5.x so contributors on - # our declared minimum (Flutter 3.27 / Dart 3.6) can still run `pub get`. + # Deliberately spans both majors rather than pinning. flutter_lints 6.x + # requires Dart 3.8+, so contributors on our declared minimum (Flutter 3.27 + # / Dart 3.6) resolve 5.x and can still run `pub get`, while newer SDKs get + # 6.x. CI analyzes on both — the pinned 3.27 job covers 5.x and the stable + # matrix covers 6.x — so neither side goes unchecked. + # + # Do not narrow this to `^6.0.0`: that breaks `pub get` on the declared + # minimum, which is why an earlier bump had to be reverted (see 5ddbd67). flutter_lints: ">=5.0.0 <7.0.0" flutter: