From a24f8d40e8cfc109d3e143916a783a91040b441d Mon Sep 17 00:00:00 2001 From: wenyiz2021 <91497961+wenyiz2021@users.noreply.github.com> Date: Wed, 1 Jul 2026 17:14:44 -0700 Subject: [PATCH] Add parameterized tests for get_manufacturer and get_model --- tests/sonic_xcvr/test_cmis.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/sonic_xcvr/test_cmis.py b/tests/sonic_xcvr/test_cmis.py index c00848bb9..5e6534e30 100755 --- a/tests/sonic_xcvr/test_cmis.py +++ b/tests/sonic_xcvr/test_cmis.py @@ -143,6 +143,17 @@ def setup_method(self, method): self.api._cdb_fw_hdlr = None self.api._init_cdb_fw_handler = False + @pytest.mark.parametrize("mock_response, expected", [ + ("VENDOR_NAME", "VENDOR_NAME"), + ("A\x00\x00\x00\x00\x00Networks\n", "ANetworks"), + ]) + def test_get_manufacturer(self, mock_response, expected): + self.api.xcvr_eeprom.read = MagicMock() + self.api.xcvr_eeprom.read.return_value = mock_response + self.clear_cache('get_manufacturer') + result = self.api.get_manufacturer() + assert result == expected + @pytest.mark.parametrize("mock_response, expected", [ ("1234567890", "1234567890"), ("ABCD", "ABCD")