Skip to content

Deflake the drawer Escape-close e2e test in sona-site #408

Description

@linear-code

e2e/drawer.spec.ts ("opening traps focus; Escape closes and returns focus to the toggle") fails intermittently in sona-site: 2 failures across 6 full-suite runs, always the same assertion — after Escape, #mnav stays visible for the full 5s timeout, so the keydown handler never fired. It passes 3 of 3 in isolation, so the failure only appears under fullyParallel load. playwright.config.ts sets retries: 2 on CI, which reports it as "flaky" instead of red — that's why it has survived.

Surfaced during the /ship review of sona-site's fix/terracotta-dot branch (theme-dot hex correction); confirmed pre-existing — that branch touches only showcase.html dot hexes, styles.css, and two test files, nothing near the drawer.

Suggested direction from the reviewer: the Escape keydown listener appears to race with the preceding 12 Tab presses under parallel load. Awaiting a settled focus state before pressing Escape, or binding the handler at document level, should deflake it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingopsCI, deployment, infra, bots

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions