Fix(solver): Correct Free Hit budget constraint and FT hit logic#55
Open
TommyContii wants to merge 2 commits into
Open
Fix(solver): Correct Free Hit budget constraint and FT hit logic#55TommyContii wants to merge 2 commits into
TommyContii wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am submitting this PR as part of the group working with Alexandre Le Saux (Master of Data Science at CentraleSupélec).
This PR addresses the two bugs you described regarding the solver constraints:
Free Hit Budget: Fixed the fh_budget constraint (line 463). It now correctly uses buy_price (instead of fh_sell_price) to calculate the cost of the new Free Hit squad, while keeping the budget calculation based on selling prices.
Free Transfer Logic: Fixed the ft_below_lb logic for hit scenarios (around line 487). I adjusted the boundary conditions so that raw_gw_ft < 1 triggers the hit logic. This ensures that taking a single hit (resulting in 0 rollover transfers) is correctly identified, granting 1 FT the following week.
Thank you for your time and the guidance on these issues!