Skip to content

Stated motivation about post-push-status.sh scraper benefit is inaccurate #82

Description

@twistedmelonman

Non-Blocking Review Concern: Stated motivation about post-push-status.sh scraper benefit is inaccurate

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:563-568
Date: 2026-05-01

What was flagged

The block comment claims minimization helps post-push-status.sh and similar scrapers stop treating PASS comments as findings. However, ~/.claude/scripts/post-push-status.sh uses the GitHub REST API (repos/{owner}/{repo}/issues/{pr}/comments), which does NOT expose isMinimized and continues to return the full body for minimized comments. The scraper matches claude[bot] author with no marker-body filter, so PASS comments would still surface as findings post-minimization. This is pre-existing (the scraper-pollution problem exists before this diff and remains after), and the new step still provides a real benefit (collapsed PR-thread UI for humans, GraphQL-based tooling). But the inline comment overstates the runtime effect — either update post-push-status.sh to use GraphQL with an isMinimized==false filter, or rephrase the comment to describe the actual UI/audit-trail benefit.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions