Non-Blocking Review Concern: Ignore-file parser doesn't strip inline comments, diverging from existing convention
Source: pre-push whole-codebase review
Location: nightowl-restore-blocking-review.sh:47
Date: 2026-04-30
What was flagged
mapfile -t IGNORED < <(grep -v '^#' "$IGNORE_FILE" 2>/dev/null | grep -v '^$' || true) only strips full-line comments and blank lines. Existing pattern in claude-review-audit.sh:46 (line="${line%%#*}") and bulk-install-claude-review.sh:90 strips inline comments and trailing whitespace. The current .claude-review-ignore file has no inline comments, so this works today, but it's inconsistent with the project convention and would silently fail to ignore a repo if someone added repo # reason later. Non-blocking; mirroring the existing pattern would be a one-line cleanup.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Ignore-file parser doesn't strip inline comments, diverging from existing convention
Source: pre-push whole-codebase review
Location:
nightowl-restore-blocking-review.sh:47Date: 2026-04-30
What was flagged
mapfile -t IGNORED < <(grep -v '^#' "$IGNORE_FILE" 2>/dev/null | grep -v '^$' || true)only strips full-line comments and blank lines. Existing pattern inclaude-review-audit.sh:46(line="${line%%#*}") andbulk-install-claude-review.sh:90strips inline comments and trailing whitespace. The current.claude-review-ignorefile has no inline comments, so this works today, but it's inconsistent with the project convention and would silently fail to ignore a repo if someone addedrepo # reasonlater. Non-blocking; mirroring the existing pattern would be a one-line cleanup.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh