Skip to content

Hardcoded absolute IGNORE_FILE path makes scripts non-portable across worktrees #79

Description

@twistedmelonman

Non-Blocking Review Concern: Hardcoded absolute IGNORE_FILE path makes scripts non-portable across worktrees

Source: pre-push whole-codebase review
Location: nightowl-restore-blocking-review.sh:17, nightowl-ruleset-rollout.sh.broken:287
Date: 2026-04-30

What was flagged

Both new scripts hardcode IGNORE_FILE="/Volumes/extra-vieille/Workspaces/github-workflows/.claude-review-ignore". The user has an additional working directory at /Users/andrewrich/Developer/github-workflows per the session context — running these scripts from there would fail to find the ignore file. The existing pattern in bulk-install-claude-review.sh:46 and claude-review-audit.sh:29 uses IGNORE_FILE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/.claude-review-ignore" to compute the path relative to the script. Adopting that pattern would make these one-off recovery scripts portable. Non-blocking because the rollout is paused and the scripts aren't expected to be re-run from the alt worktree without an explicit fix-up first.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions