Silent API error swallowing can misclassify a repo as MISSING on transient failures

[twistedmelonman]

Non-Blocking Review Concern: Silent API error swallowing can misclassify a repo as MISSING on transient failures

Source: pre-push whole-codebase review
Location: bulk-install-claude-review.sh:157-158, 280-281
Date: 2026-04-30

What was flagged

find_caller_file calls gh api ... 2>/dev/null || echo "". A transient 5xx, network blip, or auth scope issue produces an empty file list — indistinguishable from "no workflow files". The repo is then classified MISSING and (in --apply) a PR is opened to install .github/workflows/claude-code-review.yml, which would conflict with whatever already exists. Distinguish "directory empty/absent" (HTTP 404) from "API error" (other status); on error, classify as REPOS_ERROR and skip rather than treating as MISSING.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.

---

Created by lib-review-issues.sh

[twistedmelonman]

Closing per fleet-wide issue triage. Verified this cosmetic tech-debt finding is still technically accurate in current code, but it's a low-value, non-blocking style/hardening nit in internal tooling scripts (not a bug, not planned future work, no user-facing impact — misclassification risk in bulk-install-claude-review.sh is real but low-likelihood per the issue's own analysis). Closing to declutter backlog; re-file if it causes an actual incident during future fleet rollouts.