Non-Blocking Review Concern: Uploaded file content loses trailing newline via $() command substitution
Source: pre-push whole-codebase review
Location: bulk-install-claude-review.sh:102, 306, 354
Date: 2026-04-30
What was flagged
CANONICAL_CONTENT="$(fetch_file ...)", current_content="$(fetch_file ...)", and new_content="$(echo ... | sed ...)" all strip trailing newlines via bash command substitution. The PUT'd file therefore lacks a final \n, drifting from the canonical source and violating the "text files end with newline" convention. Append a newline before base64-encoding (e.g., printf "%s\n" "${file_content}" | base64 ...).
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Uploaded file content loses trailing newline via
$()command substitutionSource: pre-push whole-codebase review
Location:
bulk-install-claude-review.sh:102, 306, 354Date: 2026-04-30
What was flagged
CANONICAL_CONTENT="$(fetch_file ...)",current_content="$(fetch_file ...)", andnew_content="$(echo ... | sed ...)"all strip trailing newlines via bash command substitution. The PUT'd file therefore lacks a final\n, drifting from the canonical source and violating the "text files end with newline" convention. Append a newline before base64-encoding (e.g.,printf "%s\n" "${file_content}" | base64 ...).Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh