Non-Blocking Review Concern: has_customization uses \s while the rest of the codebase uses [[:space:]]
Source: pre-push whole-codebase review
Location: bulk-install-claude-review.sh:149
Date: 2026-04-30
What was flagged
The new script uses ^\s* in has_customization, while claude-review-audit.sh and the rest of bulk-install-claude-review.sh itself consistently use POSIX [[:space:]]. macOS BSD grep -E does support \s in modern releases, but the inconsistency is a portability/style smell — and if the regex ever silently fails to match leading whitespace under a different grep variant, customized callers will be falsely classified as un-customized and get auto-bumped, defeating the whole "human review" guard. Replace with ^[[:space:]]* to match the codebase convention.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern:
has_customizationuses\swhile the rest of the codebase uses[[:space:]]Source: pre-push whole-codebase review
Location:
bulk-install-claude-review.sh:149Date: 2026-04-30
What was flagged
The new script uses
^\s*inhas_customization, whileclaude-review-audit.shand the rest ofbulk-install-claude-review.shitself consistently use POSIX[[:space:]]. macOS BSDgrep -Edoes support\sin modern releases, but the inconsistency is a portability/style smell — and if the regex ever silently fails to match leading whitespace under a different grep variant, customized callers will be falsely classified as un-customized and get auto-bumped, defeating the whole "human review" guard. Replace with^[[:space:]]*to match the codebase convention.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh