Skip to content

has_customization uses \s while the rest of the codebase uses [[:space:]] #68

Description

@twistedmelonman

Non-Blocking Review Concern: has_customization uses \s while the rest of the codebase uses [[:space:]]

Source: pre-push whole-codebase review
Location: bulk-install-claude-review.sh:149
Date: 2026-04-30

What was flagged

The new script uses ^\s* in has_customization, while claude-review-audit.sh and the rest of bulk-install-claude-review.sh itself consistently use POSIX [[:space:]]. macOS BSD grep -E does support \s in modern releases, but the inconsistency is a portability/style smell — and if the regex ever silently fails to match leading whitespace under a different grep variant, customized callers will be falsely classified as un-customized and get auto-bumped, defeating the whole "human review" guard. Replace with ^[[:space:]]* to match the codebase convention.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions