Non-Blocking Review Concern: TARGET_VERSION extraction skips comment-stripping (inconsistent with extract_pin)
Source: pre-push whole-codebase review
Location: bulk-install-claude-review.sh:108-110
Date: 2026-04-30
What was flagged
The TARGET_VERSION extraction at the top of the script reads the canonical stub directly without strip_comments, while the per-repo extract_pin helper (lines 137-140) does strip comments. If the canonical caller stub at smartwatermelon/.github/workflow-templates/claude-blocking-review.yml ever contains a commented reference like # Bumped from @v2.0.0 to @v3.0.0 BEFORE the actual uses: line, grep -m1 will pick the comment's version. Since TARGET_VERSION is the script's single source of truth for STALE/CURRENT classification and pin replacement, a wrong extraction silently corrupts every PR opened by the script. Fix: pipe through strip_comments for consistency: TARGET_VERSION="$(strip_comments "${CANONICAL_CONTENT}" | grep -m1 -oE 'claude-blocking-review\.yml@[A-Za-z0-9._/-]+' | sed 's/^.*@//')". Mitigated in practice by dry-run-by-default + human review of output before --apply.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: TARGET_VERSION extraction skips comment-stripping (inconsistent with extract_pin)
Source: pre-push whole-codebase review
Location:
bulk-install-claude-review.sh:108-110Date: 2026-04-30
What was flagged
The
TARGET_VERSIONextraction at the top of the script reads the canonical stub directly withoutstrip_comments, while the per-repoextract_pinhelper (lines 137-140) does strip comments. If the canonical caller stub atsmartwatermelon/.github/workflow-templates/claude-blocking-review.ymlever contains a commented reference like# Bumped from @v2.0.0 to @v3.0.0BEFORE the actualuses:line,grep -m1will pick the comment's version. SinceTARGET_VERSIONis the script's single source of truth for STALE/CURRENT classification and pin replacement, a wrong extraction silently corrupts every PR opened by the script. Fix: pipe throughstrip_commentsfor consistency:TARGET_VERSION="$(strip_comments "${CANONICAL_CONTENT}" | grep -m1 -oE 'claude-blocking-review\.yml@[A-Za-z0-9._/-]+' | sed 's/^.*@//')". Mitigated in practice by dry-run-by-default + human review of output before--apply.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh