Non-Blocking Review Concern: Dead floor check after timeout floor formula raised to 10
Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:267-268
Date: 2026-04-28
What was flagged
The new formula TIMEOUT=$(( 10 + DIFF_LINES / 100 )) always yields ≥ 10 because DIFF_LINES from wc -l is non-negative, so the subsequent if [ "$TIMEOUT" -lt 10 ]; then TIMEOUT=10; fi can never fire. It's defensive (matches the explicit "Floor raised from 4 → 10 min" comment intent) and harmless, but unreachable. Either drop the check, or keep it and add a one-line comment noting it's a guard against future formula changes — pick whichever the team prefers for guard-style invariants.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Dead floor check after timeout floor formula raised to 10
Source: pre-push whole-codebase review
Location:
.github/workflows/claude-blocking-review.yml:267-268Date: 2026-04-28
What was flagged
The new formula
TIMEOUT=$(( 10 + DIFF_LINES / 100 ))always yields ≥ 10 becauseDIFF_LINESfromwc -lis non-negative, so the subsequentif [ "$TIMEOUT" -lt 10 ]; then TIMEOUT=10; fican never fire. It's defensive (matches the explicit "Floor raised from 4 → 10 min" comment intent) and harmless, but unreachable. Either drop the check, or keep it and add a one-line comment noting it's a guard against future formula changes — pick whichever the team prefers for guard-style invariants.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh