Skip to content

Comment's "below 8" threshold for 4-min floor activation is imprecise #55

Description

@twistedmelonman

Non-Blocking Review Concern: Comment's "below 8" threshold for 4-min floor activation is imprecise

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:268
Date: 2026-04-18

What was flagged

The new comment claims the 4-min floor activates "if a future change lowers the MAX_TURNS floor below 8". By the actual formula TIMEOUT = ceil(MAX_TURNS * 36 / 60), the 4-min floor only activates at MAX_TURNS ≤ 5 (MAX_TURNS=6 yields exactly 4m, MAX_TURNS=7 yields 5m). The paired "above 50" boundary for the 30-min ceiling is precise (activates at MAX_TURNS ≥ 51), which may mislead a future reader into trusting "below 8" as equally precise. Consider tightening to "below 6" or "at or below 5" so the two thresholds are symmetric in accuracy. No runtime impact since the active range (15–40) is well clear of both bounds.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions