Skip to content

SHA marker empty in non-pull_request trigger contexts #50

Description

@twistedmelonman

Non-Blocking Review Concern: SHA marker empty in non-pull_request trigger contexts

Source: claude (self-review bot)
Location: .github/workflows/claude-blocking-review.yml:392
PR: #47 — feat: doc-only fast-skip + SHA marker + prior-comment collapse (#47)
Date: 2026-04-18

What was flagged

${{ github.event.pull_request.head.sha }} is undefined when this reusable workflow is called from a workflow_dispatch or push trigger, producing a marker like <!-- claude-blocking-review sha= run=12345 -->. Downstream status scrapers would need to tolerate an absent SHA. Consider accepting an optional head_sha input with the event SHA as a fallback.

Context

This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #47. It was safe to merge but worth tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions