Non-Blocking Review Concern: Inconsistent -f vs -F usage for GraphQL ID variable
Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:289
Date: 2026-04-18
What was flagged
The minimize step's query comment (lines 262-264) correctly documents using -f (explicit string) for String! variables so integer-looking values don't fail schema validation. The subsequent mutation uses -F id="$id" for an ID! parameter, which is serialized the same way as a String. In practice this is safe because GitHub Relay node IDs are Base64-encoded and always contain non-digit characters, but for consistency with the stated rationale, -f id="$id" would be more correct and defensive against any future ID format change.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: Inconsistent
-fvs-Fusage for GraphQL ID variableSource: pre-push whole-codebase review
Location:
.github/workflows/claude-blocking-review.yml:289Date: 2026-04-18
What was flagged
The minimize step's query comment (lines 262-264) correctly documents using
-f(explicit string) forString!variables so integer-looking values don't fail schema validation. The subsequent mutation uses-F id="$id"for anID!parameter, which is serialized the same way as a String. In practice this is safe because GitHub Relay node IDs are Base64-encoded and always contain non-digit characters, but for consistency with the stated rationale,-f id="$id"would be more correct and defensive against any future ID format change.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh