Skip to content

Minimize step reads only first 100 comments in creation-ascending order #42

Description

@twistedmelonman

Non-Blocking Review Concern: Minimize step reads only first 100 comments in creation-ascending order

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:262
Date: 2026-04-18

What was flagged

comments(first: 100) returns the OLDEST 100 comments by default. On very active PRs with >100 total comments, newer claude-blocking-review markers (which sit at the end of the timeline) could fall outside the window and never be minimized. The select(.isMinimized == false) filter reduces the practical blast radius since earlier markers get minimized on subsequent runs, but a PR that crosses 100 comments in a single iteration could leak stale reviews. Consider comments(last: 100) or paginating if this becomes a real problem.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions