Skip to content

Escape-hatch grep pattern does not match documented format #40

Description

@twistedmelonman

Non-Blocking Review Concern: Escape-hatch grep pattern does not match documented format

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:305
Date: 2026-04-18

What was flagged

The check uses grep -qF '[skip-claude-review]' (fixed string, literal brackets), but every user-facing doc instructs writing [skip-claude-review: reason] — which contains no substring [skip-claude-review] because the closing ] sits after : reason. Documented format never matches, silently breaking the escape hatch. Pre-existing in claude-blocking-review.yml (this diff only adds self-review.yml). Fix: use grep -qE '\[skip-claude-review(:[^]]*)?\]' or match the prefix [skip-claude-review.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions