From 96c8ade485df7b6f7398e88ae12873cdd0f6939b Mon Sep 17 00:00:00 2001 From: Max Haarhaus Date: Sun, 21 Jun 2026 17:12:09 -0400 Subject: [PATCH] fix: remove redundant tag push in release workflow gh release create already creates the git tag on the remote when it doesn't yet exist (per gh release create --help). The separate 'Create and push tag' step that followed it therefore attempted to push a tag that already existed, which git rejected with: ! [rejected] v0.1.1 -> v0.1.1 (already exists) Removing the redundant step lets gh release create own both the release and the tag atomically. Downstream jobs (build-artifacts, publish-zed, publish-neovim) already checkout ref: ${{ needs.tag-and-release.outputs.tag }} and continue to work since the tag is created before they run. --- .github/workflows/release.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 29608fd..82dcd59 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -82,14 +82,6 @@ jobs: --title "Synthpunk ${{ steps.version.outputs.tag }}" \ --notes-file /tmp/release-notes.md - - name: Create and push tag - if: steps.tag-check.outputs.is_release == 'true' - run: | - git config user.name "github-actions[bot]" - git config user.email "41898282+github-actions[bot]@users.noreply.github.com" - git tag "${{ steps.version.outputs.tag }}" - git push origin "${{ steps.version.outputs.tag }}" - build-artifacts: name: Build and upload release artifacts needs: tag-and-release