From b88967110312f2dbdd5bae2dd330d8820b061f10 Mon Sep 17 00:00:00 2001 From: Sleeyax Date: Mon, 9 Nov 2026 12:16:08 +0100 Subject: [PATCH] feat(skills): rebuild and reload plugins from a script Nothing in update-plugins needs an agent's judgment, and a machine-wide update script has to run it unattended without spending tokens or broad permissions. scripts/rebuild-plugins.sh now owns the builds and reloads, and works on the checkout as it stands so each caller keeps its own git rules. The skill keeps the pull, the terminal for a reload that would end its own session, and the report. Reloading claude-tty last is gone: it only protected a run hosted on that provider, which the hosting-provider check already covers, and claude-tty is due to be phased out. Co-Authored-By: Claude Opus 5.5 --- scripts/rebuild-plugins.sh | 75 +++++++++++++++++++++++++ skills/update-plugins/SKILL.md | 100 +++++++++------------------------ 2 files changed, 101 insertions(+), 74 deletions(-) create mode 100755 scripts/rebuild-plugins.sh diff --git a/scripts/rebuild-plugins.sh b/scripts/rebuild-plugins.sh new file mode 100755 index 0000000..100a0aa --- /dev/null +++ b/scripts/rebuild-plugins.sh @@ -0,0 +1,75 @@ +#!/usr/bin/env bash +# Builds and reloads every plugin the daemon runs from this checkout, as it stands. +# Getting the checkout current is the caller's job. +set -euo pipefail + +root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd -P)" + +for tool in paseo pnpm jq; do + if ! command -v "$tool" >/dev/null; then + echo "Error: $tool not found on PATH" >&2 + exit 1 + fi +done + +listing=$(paseo plugin ls --json) +mapfile -t plugins < <(jq -r --arg root "$root/" '.[] | select(.path | startswith($root)) | "\(.id)\t\(.path)"' <<<"$listing") + +if [ "${#plugins[@]}" -eq 0 ]; then + echo "No plugins installed from $root" + exit 0 +fi + +# A reload closes every session on the plugin's provider, including the one running this. +hosting_provider="" +if [ -n "${PASEO_AGENT_ID:-}" ]; then + hosting_provider=$(paseo inspect "$PASEO_AGENT_ID" --json | jq -r '.Provider // empty') +fi + +workspace_installed=0 + +run_manifest_build() { + local id=$1 dir=$2 line + local -a build argv + mapfile -t build < <(jq -c '.build // [] | .[]' "$dir/paseo-plugin.json") + + for line in ${build[@]+"${build[@]}"}; do + mapfile -t argv < <(jq -r '.[]' <<<"$line") + + # One frozen install covers the whole pnpm workspace. + if [ "${argv[*]}" = "pnpm install --frozen-lockfile" ]; then + [ "$workspace_installed" -eq 0 ] || continue + workspace_installed=1 + fi + + echo "==> $id: ${argv[*]}" + if ! (cd "$dir" && "${argv[@]}" &2 + exit 1 + fi + done +} + +for plugin in "${plugins[@]}"; do + IFS=$'\t' read -r id dir <<<"$plugin" + run_manifest_build "$id" "$dir" +done + +failed=0 +for plugin in "${plugins[@]}"; do + IFS=$'\t' read -r id dir <<<"$plugin" + + if [ "$id" = "$hosting_provider" ]; then + echo "Skipped reload of $id: it hosts this session. Run: paseo plugin reload $id --json" + continue + fi + + status=$(paseo plugin reload "$id" --json | jq -r '.status') || status="reload failed" + echo "$id: $status" + if [ "$status" != "running" ]; then + failed=1 + paseo plugin logs "$id" >&2 || true + fi +done + +exit "$failed" diff --git a/skills/update-plugins/SKILL.md b/skills/update-plugins/SKILL.md index 52d92e8..1f16374 100644 --- a/skills/update-plugins/SKILL.md +++ b/skills/update-plugins/SKILL.md @@ -6,21 +6,12 @@ description: Rebuild and reload the paseo plugins installed on this host from th # Update the plugins installed from this repo Every plugin in this repository is installed against its own directory, so the daemon runs these files directly. -"Update" therefore means: get the working copy current, run the builds a directory install never runs itself, reload so the daemon recompiles the client and server bundles, and confirm each one is running. - -Nothing here is specific to one coding agent. It is shell commands and the files in this checkout. - -## Requirements - -`paseo` and `pnpm` must both be on `PATH`. If either is missing, say which and stop — there is nothing useful to do without it. +"Update" therefore means: get the working copy current, then run `scripts/rebuild-plugins.sh`, which runs the builds a directory install never runs itself and reloads each plugin so the daemon recompiles its bundles. ## Hard rules -- **Only act on plugins the daemon already has.** `paseo plugin ls` is the list. A plugin that exists under `plugins/` but is not installed is not this skill's business — do not install it, do not mention it. -- **Never touch git beyond a fast-forward pull.** No stash, no checkout, no fetch-and-reset. If the pull does not apply cleanly under the conditions below, skip it and rebuild the working copy as it stands. -- **Never reload the provider hosting this session.** A reload closes every session on that provider, this one included, so the command never returns and the run ends in a system error. Type it into a workspace terminal for the user to run instead. -- **Reload `claude-tty` last.** A reload closes the other sessions on its provider too. Everything else must be finished before that risk is taken. -- **Report failures with their output.** A build that fails, a plugin that comes back `error` — say so and quote the error. Do not reload on top of a failed build and call it done. +- **Keep git to a fast-forward pull.** If the pull does not apply cleanly under the conditions below, skip it and rebuild the working copy as it stands. +- **Report failures with their output.** A build that fails, a plugin that comes back `error`: say so and quote the error. ## Steps @@ -32,35 +23,11 @@ This skill can be installed globally, so it cannot assume where it is running. git rev-parse --show-toplevel 2>/dev/null ``` -The repository root must contain `pnpm-workspace.yaml` and a `plugins/` directory holding `paseo-plugin.json` manifests. If it does not, this is not the paseo-plugins checkout — say so and stop. Everything below runs from that root. - -### 1. Gather the state — one shell invocation - -Batch it; do not spend a round trip per fact. - -```sh -paseo plugin ls -paseo plugin ls --json -git status --short --branch -git rev-parse --abbrev-ref --symbolic-full-name '@{u}' 2>&1 -[ -n "$PASEO_AGENT_ID" ] && paseo inspect "$PASEO_AGENT_ID" --json -[ -n "$PASEO_AGENT_ID" ] && jq -r .workspaceId "${PASEO_HOME:-$HOME/.paseo}"/agents/*/"$PASEO_AGENT_ID".json -``` - -From `ls --json` take the `id` and `path` of every installed plugin. Keep the ones whose `path` is inside this repository; drop the rest. - -The table adds a `SOURCE` column the JSON does not have: - -- `directory` — the daemon runs this working copy. These are what the rest of this skill handles. -- `git` — the daemon runs its own clone, and nothing local reaches it. For those, `paseo plugin update ` is the whole update; it fetches and runs the manifest build in the daemon's checkout. Run it, report it, and leave them out of steps 3–4. - -If nothing survives the filter, say so and stop. +The repository root must contain `pnpm-workspace.yaml` and a `plugins/` directory holding `paseo-plugin.json` manifests. +If it does not, this is not the paseo-plugins checkout: say so and stop. +Everything below runs from that root. -`PASEO_AGENT_ID` is set when Paseo hosts this session, and `Provider` in the `inspect` output names the provider it runs on. -A plugin whose `id` equals that provider is the one hosting this session: build it like the rest, but leave it out of the reloads in step 4. -The `jq` line reads the workspace this session belongs to from the daemon's agent record, because `inspect` leaves it out; step 4 needs it for that plugin's terminal. - -### 2. Pull, but only when it is free +### 1. Pull, but only when it is free Pull only when all three hold: the working tree is clean, `HEAD` is the default branch, and it has an upstream. @@ -68,60 +35,45 @@ Pull only when all three hold: the working tree is clean, `HEAD` is the default git pull --ff-only ``` -Otherwise skip it and name the reason in one clause — dirty tree, on a branch, no upstream. A skipped pull is not an error; the rebuild still runs against what is checked out. - -### 3. Run each plugin's manifest build - -`paseo-plugin.json` holds the `build` array the daemon runs on a git install, and it is the authority on what a plugin needs built. -A directory install runs none of it, which is why the app under `apps/` goes stale. +Otherwise skip it and name the reason in one clause: dirty tree, on a branch, no upstream. +A skipped pull is not an error; the rebuild still runs against what is checked out. -For each surviving plugin, read `plugins//paseo-plugin.json`. Plugins with no `build` key need nothing. For the ones that have it, run each command **from that plugin's directory** — `pnpm` walks up to the workspace root from there, and the manifest's filters are written expecting that cwd: +### 2. Rebuild and reload ```sh -cd plugins/claude-tty -pnpm install --frozen-lockfile -pnpm --filter @paseo-plugins/claude-tty-acp build +scripts/rebuild-plugins.sh ``` -Deduplicate across plugins: `pnpm install --frozen-lockfile` covers the whole workspace, so run it once no matter how many manifests ask for it. +The script covers every plugin the daemon runs from this checkout, and a non-zero exit means something failed. +Read its output for the three cases below. -If `--frozen-lockfile` fails, the lockfile is behind `package.json`. Report that and stop — do not swap in a plain `pnpm install` to get past it, because that changes the lockfile the daemon installs from. - -### 4. Reload, `claude-tty` last - -```sh -paseo plugin reload --json -``` +If `--frozen-lockfile` failed, the lockfile is behind `package.json`, which is a problem to report, because a plain `pnpm install` would change the lockfile the daemon installs from. -`status` in the response is the answer: `running` is a clean reload, anything else is a failure. Reload is the compile check for `index.client.tsx` and `index.server.ts`, so a bundle that no longer compiles surfaces here. +A plugin in `paseo plugin ls` whose `SOURCE` is `git` runs from the daemon's own clone, so nothing local reaches it and the script leaves it out. +`paseo plugin update ` is its whole update. -Skip the plugin hosting this session, if step 1 found one, and type its reload into a terminal of this workspace without pressing Enter, so the user runs it once they are done with the session: +A line starting `Skipped reload of ` means that plugin's provider hosts this session, and a reload would end it. +Type the reload into a terminal of this workspace without pressing Enter, so the user runs it once they are done with the session: ```sh -terminal=$(paseo terminal create --workspace --cwd "$PWD" --name "reload " -q) +workspace=$(jq -r .workspaceId "${PASEO_HOME:-$HOME/.paseo}"/agents/*/"$PASEO_AGENT_ID".json) +terminal=$(paseo terminal create --workspace "$workspace" --cwd "$PWD" --name "reload " -q) paseo terminal send-keys --literal "$terminal" 'paseo plugin reload --json' ``` -Pass the workspace from step 1 rather than relying on `--cwd`: given a directory alone, the daemon picks one of the workspaces open on it, and with several open on this checkout that is often not the user's. Address the terminal by the ID `create` prints, since a name can match a leftover terminal from an earlier run. -If step 1 found no agent record, drop `--workspace` and name the workspace the terminal landed in, from `paseo terminal ls --json` and `paseo workspace ls --json`, so the user knows where to look. - +Pass the workspace rather than relying on `--cwd`: given a directory alone, the daemon picks one of the workspaces open on it, and with several open on this checkout that is often not the user's. +Address the terminal by the ID `create` prints, since a name can match a leftover terminal from an earlier run. The daemon owns that terminal, so it outlives the sessions the reload closes. -For any plugin that did not come back `running`, read its output: - -```sh -paseo plugin logs -``` - -### 5. Report +### 3. Report One short summary: -- Whether the pull ran, and the commit range it brought in — or why it was skipped. -- What was rebuilt. +- Whether the pull ran, and the commit range it brought in, or why it was skipped. - Each plugin reloaded, with its status. - Anything that failed, with the error. - When a plugin was skipped because it hosts this session, end by pointing the user at the `reload ` terminal, and say that pressing Enter there closes this session. -When `claude-tty` was among them, add the one caveat that is not visible from the status: an adapter process keeps the code it started with, so the rebuilt adapter reaches only sessions started after the reload. Existing sessions carry the old one until they are restarted. +When `claude-tty` was among them, add the one caveat that is not visible from the status: an adapter process keeps the code it started with, so the rebuilt adapter reaches only sessions started after the reload. +Existing sessions carry the old one until they are restarted. Its adapter log is `~/.local/state/claude-tty-acp/logs/claude-tty-acp.log`, separate from the plugin's own `paseo plugin logs claude-tty`, because the daemon drops the adapter's stderr.