Skip to content
This repository was archived by the owner on Feb 18, 2026. It is now read-only.
This repository was archived by the owner on Feb 18, 2026. It is now read-only.

com.atproto.identity.getRecommendedDidCredentials doesn't actually return the current DID document #16

Description

@ThisIsMissEm

In plcSetupLabeler, com.atproto.identity.getRecommendedDidCredentials is called as part of creating an operation to submit to did:plc, however, that method doesn't actually return the current state of the did document, just the data that the PDS knows about, so if you had additional services or verificationMethods in your did document, then there's a chance that plcSetupLabeler would remove those verification methods & services from your did document.

I suspect we may actually want to fetch both the recommend did credentials, and the did document itself, and then merge in order of new labeler data, did document data, recommended credentials data.

This would prevent setting up a labeler from interfering with anything else that happens to already be on the did document.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions