Skip to content

Commit fc8740a

Browse files
yyq1025claude
andcommitted
ci: generate gitignored workerd types before typecheck
worker-configuration.d.ts is a regenerable artifact (deliberately untracked) — without `wrangler types` the signaling package typechecks against zero runtime globals (Env/Response/crypto/...) and the first CI run failed exactly there. Generate it in both workflows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent ef442bf commit fc8740a

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@ jobs:
2323
- name: biome
2424
run: pnpm exec biome ci .
2525

26+
# worker-configuration.d.ts (workerd runtime globals: Env/Response/...)
27+
# is gitignored as a regenerable artifact — generate it or the
28+
# signaling typecheck has no runtime types.
29+
- name: Generate workerd types (signaling)
30+
run: pnpm --filter @sidecodeapp/signaling run cf-typegen
31+
2632
- name: Typecheck (workspace)
2733
run: pnpm -r typecheck
2834

.github/workflows/release-menubar.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ jobs:
6060
6161
- name: Typecheck + tests
6262
run: |
63+
pnpm --filter @sidecodeapp/signaling run cf-typegen # gitignored workerd types
6364
pnpm -r typecheck
6465
pnpm test
6566

0 commit comments

Comments
 (0)