Skip to content

Commit 494f098

Browse files
yyq1025claude
andcommitted
menubar: electron 42.4.0 + vite-plugin-electron 1.0.4 (beta → stable); document expected build warnings
Both electron-builder warnings are by-design with pnpm + arm64-only distribution and now say so in the config: the missing platform binaries are every platform we don't ship (darwin-arm64 IS bundled), and the duplicate references are pnpm's nested layout reaching shared deps through both menubar and the daemon link. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 90fc968 commit 494f098

3 files changed

Lines changed: 34 additions & 66 deletions

File tree

packages/menubar/electron-builder.cjs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,16 @@ module.exports = {
2424
// source. The SDK's per-platform `claude` SEA binary (~212MB) IS bundled —
2525
// sidecode spawns it (Desktop-style) instead of resolving a system claude,
2626
// feeding it the keychain OAuth token via env (see daemon bridge/credentials).
27+
//
28+
// Two electron-builder build warnings are EXPECTED with this setup:
29+
// - "platform-specific optional dependencies not bundled" (darwin-x64 /
30+
// linux-* / win32-* SDK binaries): pnpm installs only the host platform's
31+
// binary and V0 ships arm64-mac only — darwin-arm64 IS bundled, the rest
32+
// are intentionally absent. Revisit only if we ever add an x64 target.
33+
// - "duplicate dependency references": pnpm's nested layout makes some deps
34+
// reachable via multiple paths (menubar → daemon link → shared deps);
35+
// informational, worst case a few duplicated JS copies in the asar —
36+
// noise next to the 212MB SEA binary.
2737
files: ["dist/**/*", "dist-electron/**/*", "assets/**/*", "package.json"],
2838
asar: true,
2939
// Executables can't run from inside the asar archive:

packages/menubar/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@
3535
"@types/react": "^19.2",
3636
"@types/react-dom": "^19.2",
3737
"@vitejs/plugin-react": "^6.0.2",
38-
"electron": "42.1.0",
38+
"electron": "42.4.0",
39+
"electron-builder": "^26.15.2",
3940
"tailwindcss": "^4.3.0",
4041
"vite": "^8.0.13",
41-
"vite-plugin-electron": "1.0.0-beta.10",
42-
"electron-builder": "^26.15.2"
42+
"vite-plugin-electron": "1.0.4"
4343
}
4444
}

pnpm-lock.yaml

Lines changed: 21 additions & 63 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)