Skip to content

TS - Message.unpack fails with silent SIGBUS error #97

@vongohren

Description

@vongohren

What

Have friendly errors when a method can receive all types, DO NOT crash with a SIGBUS error.
Sending inn a JSON obj into unpack, which is allowed by the types, crashes silently with a SIGBUS error. Trying to debug this was not that easy: nodejs/help#3168

But the library should throw a friendly error if JSON objects are not possible to send in for unpack.
Only string works at the moment

Why

This needs to be fixed for a better DX, as SIGBUS is not caught by try catch, and it can fail silently depending on how one run its code. This is a very bad DX.

Success Criteria

Fail if one send in something the unpack method dont expect. Fail with a proper error so the developer can understand.
Or if JSON objects are OK, which they should be, dont crash unexpectadly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions