From 014a59d7d5b88dbf9f9f1c2ccfd7c6e95abda48b Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 29 Jul 2026 12:10:38 +0000 Subject: [PATCH] test(inbound): lift side-effecting delete calls out of assert statements CodeQL flags `assert is True` because the call is skipped when asserts are disabled (python -O). Assign each delete() result to a local first, then assert on the value. Resolves the four "assert statement has a side-effect" code-scanning alerts on tests/test_inbound.py. No behavior change. --- tests/test_inbound.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/test_inbound.py b/tests/test_inbound.py index 6a36102..84a4c31 100644 --- a/tests/test_inbound.py +++ b/tests/test_inbound.py @@ -56,7 +56,8 @@ def test_delete_inbound_address(client): respx.delete(f"{BASE_URL}/v1/inbound/addresses/inb_1").mock( return_value=httpx.Response(200, json={"deleted": True}) ) - assert client.inbound.addresses.delete("inb_1") is True + deleted = client.inbound.addresses.delete("inb_1") + assert deleted is True @respx.mock @@ -265,7 +266,8 @@ def test_delete_inbound_domain(client): respx.delete(f"{BASE_URL}/v1/inbound/domains/d3").mock( return_value=httpx.Response(200, json={"deleted": True}) ) - assert client.inbound.domains.delete("d3") is True + deleted = client.inbound.domains.delete("d3") + assert deleted is True @respx.mock @@ -360,7 +362,8 @@ async def test_delete_inbound_domain_async(aclient): respx.delete(f"{BASE_URL}/v1/inbound/domains/d3").mock( return_value=httpx.Response(200, json={"deleted": True}) ) - assert await aclient.inbound.domains.delete("d3") is True + deleted = await aclient.inbound.domains.delete("d3") + assert deleted is True @respx.mock @@ -405,7 +408,8 @@ async def test_async_inbound_addresses_full_surface(aclient): respx.delete(f"{BASE_URL}/v1/inbound/addresses/inb_9").mock( return_value=httpx.Response(200, json={"deleted": True}) ) - assert await aclient.inbound.addresses.delete("inb_9") is True + deleted = await aclient.inbound.addresses.delete("inb_9") + assert deleted is True @respx.mock