Environment Details
Error Description
When a benchmark run times out, the benchmark launcher finalizes the run by filling in missing results*.csv files from available per-job artifacts. However, BenchmarkLauncher.finalize() processes every launched instance, including instances that already completed successfully and already uploaded both results*.csv and metainfo*.yaml.
For those completed instances, finalization should leave results*.csv and metainfo*.yaml untouched. The finalized completed_date format is also inconsistent with normal benchmark completion:
- normal benchmark path:
%m_%d_%Y %H:%M:%S
- launcher finalize path:
%d_%m_%Y %H:%M:%S
Expected behavior:
- Completed instances should be skipped during finalization.
- Existing
results*.csv files should not be rewritten.
- Existing completed
metainfo*.yaml files should not have completed_date changed.
- Finalization timestamps should use the same format as normal benchmark completion.
Environment Details
Error Description
When a benchmark run times out, the benchmark launcher finalizes the run by filling in missing
results*.csvfiles from available per-job artifacts. However,BenchmarkLauncher.finalize()processes every launched instance, including instances that already completed successfully and already uploaded bothresults*.csvandmetainfo*.yaml.For those completed instances, finalization should leave
results*.csvandmetainfo*.yamluntouched. The finalizedcompleted_dateformat is also inconsistent with normal benchmark completion:%m_%d_%Y %H:%M:%S%d_%m_%Y %H:%M:%SExpected behavior:
results*.csvfiles should not be rewritten.metainfo*.yamlfiles should not havecompleted_datechanged.