Feature Request - Tag Border and Tag Custom Font

[yad027]

Hi there! First of all, thank you for your great work. I've been using Hashtags for a while. It's easy to use and powerful.

However, I recently encountered a requirement from my UI designer which required to use a border version of the Hashtags. I've checked the code and found there's no open variable or configuration to implement through using the Hashtags framework. Got the same issue with the custom font.

Thus I'm wondering if it is possible to add this new feature.

[Yonodactyl]

This is a good idea. There could be an optional variable in HashtagConfiguration that can be used to add a border to the removable hashtag button.

I could take a crack at this.

edit: it seems this project has not been updated in a while. I don’t know if the author will work on anything new.

[yad027]

Hi Yon Montoto, Thanks for your reply and consideration. Also, it's weird as although configureWithTag and configuration both are "open", there's no way to actually set the configuration of the HashTagView and its subclass.(It has a call to makeConfiguration() which is intouchable from out It' blocked me from creating a subclass of Configuration, assigning it to the HashTags, and overriding configureWithTag. Plus, custom font could also be added into the configuration. Best regards, Yanzhi

…

On Wed, Apr 8, 2020 at 8:26 PM Yon Montoto ***@***.***> wrote: This is a good idea. There could be an optional variable in HashtagConfiguration that can be used to add a border to the removable hashtag button. I could take a crack at this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHXRKFKLN2I7ZSLOT56GCM3RLU55TANCNFSM4MELZNFA> .

-- Yanzhi Ding UCSD Undergraduate (Senior) Computer Science & Economics (858) 405-8560 Wechat: Henrydyz

[Yonodactyl]

I’ve been looking over the code and I can see where I can bring in an option like border color; however, I am not near my computer today so I can’t try anything. Some time this week I’ll look over it

[Yonodactyl]

@yad027 Don't know if you want to check out my fork that I just pushed but it adds a borderwidth and color variable so that you can implement the feature.
To use this fork just replace your Podfile line:
pod 'Hashtags'
with:
pod 'Hashtags', :git => 'https://github.com/Yonodactyl/Hashtags.git'
Then inside of your HashtagView implementation set your variables like so:

lazy var hashtags: HashtagView = {
        let hashtags = HashtagView(frame: CGRect(x: 0, y: 0, width: 0, height: 70.0))
        hashtags.borderColor = .systemBlue
        hashtags.borderWidth = 2
        return hashtags
    }()

OR
Change the value inside the Inspector if you use storyboards.
Let me know if this works for you!

[yad027]

Hi Yon Montoto, Thanks for the update. Yeah, it should work. Thank you for your time. Best regards, Yanzhi

On Sat, Apr 11, 2020 at 16:39 Yon Montoto ***@***.***> wrote: @yad027 <https://github.com/yad027> Don't know if you want to check out my fork that I just pushed but it adds a borderwidth and color variable so that you can implement the feature. To use this fork just replace your Podfile line: pod 'Hashtags' with: pod 'Hashtags', :git => 'https://github.com/Yonodactyl/Hashtags.git', :commit => 'a96698131288ee9a808fbf18e118bdec36d57515' Then inside of your HashtagView implementation set your variables like so: lazy var hashtags: HashtagView = { let hashtags = HashtagView(frame: CGRect(x: 0, y: 0, width: 0, height: 70.0)) hashtags.borderColor = .systemBlue hashtags.borderWidth = 2 return hashtags }() OR Change the value inside the Inspector if you use storyboards. Let me know if this works for you! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHXRKFM47HRBFTXWAEEUQS3RMD5TNANCNFSM4MELZNFA> .

-- Yanzhi Ding UCSD Undergraduate (Senior) Computer Science & Economics (858) 405-8560 Wechat: Henrydyz

[Yonodactyl]

If approved, PR #6 would address this feature request

_{Sent with GitHawk}