Add configurable naming for variadic arguments (opt-out) and related tests/docs#16
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
name1,name2while keeping the feature configurable.Description
ALLOW_NAMED_VARIADIC_ARGUMENTStoAddNamedArgumentsRectorand expose configuration indices viaSTRATEGYandALLOW_NAMED_VARIADIC_ARGUMENTS, with the variadic option defaulting to enabled.<paramName>1,<paramName>2, etc., using internal counters.resolveParameterForArgumentIndex()helper in bothAddNamedArgumentsRectorandDefaultStrategyto unify argument-to-parameter mapping, and addedhasVariadicArguments()to early-skip refactoring when the variadic option is disabled.configure()parsing and validation to accept the new boolean variadic option and to preserve existing strategy configuration, added README clarification for the new option, and addeddocs/issue-15-implementation-plan.mddescribing the approach.Testing
tests/VariadicDisabledStrategy/AddNamedArgumentsRectorTest.phpwithtests/VariadicDisabledStrategy/Fixture/variadic_disabled.php.inc, andtests/DefaultStrategy/Fixture/variadic.php.incandvariadic_mixed_signature.php.incwere updated/added to assert variadic naming behavior.vendor/bin/phpunit) including the new and updated fixtures, and all tests passed.