Skip to content

Avoid false positives when arguments already named#14

Merged
savinmikhail merged 1 commit into
mainfrom
codex/investigate-floating-bug-in-issue-4
Dec 25, 2025
Merged

Avoid false positives when arguments already named#14
savinmikhail merged 1 commit into
mainfrom
codex/investigate-floating-bug-in-issue-4

Conversation

@savinmikhail
Copy link
Copy Markdown
Owner

Summary

  • return null from AddNamedArgumentsRector when no arguments are modified to prevent false positives
  • track argument updates in addNamesToArgs before returning the node

Testing

  • vendor/bin/phpunit

Codex Task

@savinmikhail savinmikhail merged commit 6db3a87 into main Dec 25, 2025
5 of 6 checks passed
@savinmikhail
Copy link
Copy Markdown
Owner Author

fix for #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant