Windows coverage landed with #5: test-windows runs the suite on a real windows-latest runner, and it caught nothing at the time because the fix was already correct.
It is not in required_status_checks, so it reports on a pull request without gating one. A future change that breaks generation on Windows shows a red test-windows next to a green test — and merges anyway, if nobody scrolls.
Why the gap exists: the required context is test, and adding Windows as a matrix leg would have renamed the reported checks to test (ubuntu-latest) / test (windows-latest). The required name would then never be reported again and every subsequent pull request would wait on it forever. Hence a separately-named job, which is correct but not yet required.
Suggested approach: add test-windows to the required contexts alongside test. Adding a second context is safe in a way renaming the first is not — test keeps reporting throughout, so there is no window where the gate is unsatisfiable.
This needs repository admin, so it is a maintainer action rather than a code change.
Verifying: open a throwaway pull request that breaks something Windows-only, and confirm the merge button stays blocked rather than merely showing a red check.
Windows coverage landed with #5:
test-windowsruns the suite on a realwindows-latestrunner, and it caught nothing at the time because the fix was already correct.It is not in
required_status_checks, so it reports on a pull request without gating one. A future change that breaks generation on Windows shows a redtest-windowsnext to a greentest— and merges anyway, if nobody scrolls.Why the gap exists: the required context is
test, and adding Windows as a matrix leg would have renamed the reported checks totest (ubuntu-latest)/test (windows-latest). The required name would then never be reported again and every subsequent pull request would wait on it forever. Hence a separately-named job, which is correct but not yet required.Suggested approach: add
test-windowsto the required contexts alongsidetest. Adding a second context is safe in a way renaming the first is not —testkeeps reporting throughout, so there is no window where the gate is unsatisfiable.This needs repository admin, so it is a maintainer action rather than a code change.
Verifying: open a throwaway pull request that breaks something Windows-only, and confirm the merge button stays blocked rather than merely showing a red check.