From b5f0f784df7eb11c7d0378ced70130c060dcdd2a Mon Sep 17 00:00:00 2001 From: Daniel Ahn Date: Sun, 16 Aug 2026 16:09:45 -0700 Subject: [PATCH] fix(DAN-873): CI must follow the code, not the base branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pull_request.branches filters on the PR BASE. With [main], a stacked PR — one opened against another PR branch — matched nothing and ran ZERO jobs, while GitHub still rendered a green checks column from the Vercel deployment. Measured today, same repo, same hour: PR #7 base agent-a/DAN-855-... 0 CI jobs + 2 Vercel reads "green" PR #8 base main 8 CI jobs + 2 Vercel is green Absence of a failing check is not absence of checking, and at a glance the two are identical. Stacking is a normal way to work in this repo, so removing the filter is the fix; the push trigger keeps its [main] filter, which is correct. --- .github/workflows/ci.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c3e3e0d..9d67f3d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,8 +3,20 @@ name: CI on: push: branches: [main] + # NO `branches:` filter here, deliberately (DAN-873). + # + # `pull_request.branches` filters on the PR's BASE branch. With `[main]`, a + # stacked PR — one opened against another PR's branch — matched nothing and + # ran ZERO jobs, while GitHub still rendered a green checks column from the + # Vercel deployment. Measured 2026-08-16: + # + # PR #7 base agent-a/DAN-855-… 0 CI jobs + 2 Vercel "green" + # PR #8 base main 8 CI jobs + 2 Vercel green + # + # Absence of a failing check is not the same as absence of checking, and the + # two are indistinguishable at a glance. Stacking is a normal way to work + # here, so the suite must follow the code rather than the base branch. pull_request: - branches: [main] permissions: contents: read