From e1125255e68e905386a3cba43da823db03190526 Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Wed, 29 Apr 2026 23:57:51 +0100 Subject: [PATCH] clippy: fix needless_borrow lint https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#needless_borrow Assisted-by: clippy 0.1.95 (59807616e1 2026-04-14) --- mailmap/src/lib.rs | 2 +- src/main.rs | 36 ++++++++++++++++++------------------ src/site.rs | 4 ++-- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/mailmap/src/lib.rs b/mailmap/src/lib.rs index 3ecebf6e..d9a5fda6 100644 --- a/mailmap/src/lib.rs +++ b/mailmap/src/lib.rs @@ -101,7 +101,7 @@ impl Mailmap { let file = Pin::new(file.into_boxed_str()); let mut entries = Vec::with_capacity(file.lines().count()); for (idx, line) in file.lines().enumerate() { - if let Some(entry) = parse_line(&line, idx + 1) { + if let Some(entry) = parse_line(line, idx + 1) { entries.push(entry.to_raw_entry()); } } diff --git a/src/main.rs b/src/main.rs index ac7db8ee..55e0f046 100644 --- a/src/main.rs +++ b/src/main.rs @@ -86,7 +86,7 @@ impl AuthorMap { let mut new = AuthorMap::new(); new.map.reserve(self.map.len()); for (author, set) in self.map.iter() { - if let Some(other_set) = other.map.get(&author) { + if let Some(other_set) = other.map.get(author) { let diff: HashSet<_> = set.difference(other_set).cloned().collect(); if !diff.is_empty() { new.map.insert(author.clone(), diff); @@ -175,13 +175,13 @@ fn update_repo(url: &str) -> Result> { "--dissociate", "--reference", &tmp, - &url, + url, &path_s, ])?; std::fs::remove_dir_all(&tmp)?; } } else { - git(&["clone", "--bare", &url, &path_s])?; + git(&["clone", "--bare", url, &path_s])?; } Ok(path) } @@ -232,7 +232,7 @@ impl cmp::PartialEq for VersionTag { impl cmp::PartialOrd for VersionTag { fn partial_cmp(&self, other: &Self) -> Option { - Some(self.cmp(&other)) + Some(self.cmp(other)) } } @@ -258,7 +258,7 @@ fn get_versions(repo: &Repository) -> Result, Box Result, Box commit_authors.extend(reviewers), Ok(None) => {} Err(ErrorContext(msg, e)) => { @@ -559,7 +559,7 @@ fn mailmap_from_repo(repo: &git2::Repository) -> Result f }; let file = String::from_utf8( - file.to_object(&repo)? + file.to_object(repo)? .peel_to_blob()? .content() .into(), @@ -583,9 +583,9 @@ fn up_to_release( Box::new(e), ) })?; - let modules = get_submodules(&repo, &to_commit)?; + let modules = get_submodules(repo, &to_commit)?; - let mut author_map = build_author_map(&repo, &reviewers, &mailmap, "", &to.raw_tag) + let mut author_map = build_author_map(repo, reviewers, mailmap, "", &to.raw_tag) .map_err(|e| ErrorContext(format!("Up to {}", to), e))?; for module in &modules { @@ -593,8 +593,8 @@ fn up_to_release( let subrepo = Repository::open(&path)?; let submap = build_author_map( &subrepo, - &reviewers, - &mailmap, + reviewers, + mailmap, "", &module.commit.to_string(), )?; @@ -670,11 +670,11 @@ fn generate_thanks() -> Result, Box v, - None => up_to_release(&repo, &reviewers, &mailmap, &previous)?, + None => up_to_release(&repo, &reviewers, &mailmap, previous)?, }; let current = cache.get(&version).unwrap(); @@ -725,7 +725,7 @@ fn get_submodules( repo: &Repository, at: &Commit, ) -> Result, Box> { - let submodule_cfg = modules_file(&repo, &at)?; + let submodule_cfg = modules_file(repo, at)?; let submodule_cfg = Config::parse(&submodule_cfg)?; let mut path_to_url = HashMap::new(); let entries = submodule_cfg.entries(None)?; @@ -742,7 +742,7 @@ fn get_submodules( let tree = at.tree()?; for (path, url) in &path_to_url { let path = Path::new(&path); - let entry = tree.get_path(&path); + let entry = tree.get_path(path); // the submodule may not actually exist let entry = match entry { Ok(e) => e, @@ -786,7 +786,7 @@ fn get_submodules( fn modules_file(repo: &Repository, at: &Commit) -> Result> { if let Some(modules) = at.tree()?.get_name(".gitmodules") { Ok(String::from_utf8( - modules.to_object(&repo)?.peel_to_blob()?.content().into(), + modules.to_object(repo)?.peel_to_blob()?.content().into(), )?) } else { return Ok(String::new()); diff --git a/src/site.rs b/src/site.rs index 17588ae9..cd86d0fc 100644 --- a/src/site.rs +++ b/src/site.rs @@ -220,7 +220,7 @@ fn releases( in_progress: bool, } let hb = hb()?; - let scores = author_map_to_scores(&all_time); + let scores = author_map_to_scores(all_time); let res = hb.render( "stats", @@ -238,7 +238,7 @@ fn releases( fs::write("output/rust/all-time/index.html", res)?; for (version, map) in by_version { - let scores = author_map_to_scores(&map); + let scores = author_map_to_scores(map); let res = hb.render( "stats", &Release {