-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[rustdoc] issues of the three-big-buttons #132386
Copy link
Copy link
Closed
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-discussionCategory: Discussion or questions that doesn't represent real issues.Category: Discussion or questions that doesn't represent real issues.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Metadata
Metadata
Assignees
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-discussionCategory: Discussion or questions that doesn't represent real issues.Category: Discussion or questions that doesn't represent real issues.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Type
Fields
Give feedbackNo fields configured for issues without a type.
PR #129545 introduced a new style for rustdoc API pages.
I appreciate the author's efforts. But the new style still has a few shortcomings.
That PR said:
I don't think that's right. Gear-icon for setting, question-mark-icon for help, +/--icon for folding, are widely used all over the world, the meaning is clear. The top-right position of the window is also easy to find and reach. The search box has a tip of '? for more options' in its placehold, you may type ‘?’ key to 'click' the help button. There's document in help page to help you find folding button. That's enough, for those low utilization rate buttons. Folding (aka summary) button's icon may use a different color to improve recogniztion.
That PR made those buttons very big, bigger than any other items of the page. That's an UX issue too (as i said above).
I propose:
links: new style, old style