-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
unions with only Abi::Scalar fields should get Abi::Scalar themselves #114383
Copy link
Copy link
Open
Labels
A-ABIArea: Concerning the application binary interface (ABI)Area: Concerning the application binary interface (ABI)C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-ABIArea: Concerning the application binary interface (ABI)Area: Concerning the application binary interface (ABI)C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Consider these types:
The first two are getting scalar ABI, but the last one is an aggregate. (As shown by this debug output.)
It seems reasonable to also give the last union Scalar ABI, no? Of course it should be
Scalar::Union, but still.@scottmcm ran into this in #113344.
Cc @eddyb @oli-obk (as usual for layout issues ;)