Skip to content

Off-by-one suggestion message line number when includes trailing newline #534

Description

@ehuss

When a build message includes a suggestion, and the suggestion includes the newline, the suggestion phantom is attached to the following line. Although this makes sense from the perspective that the end of the phantom really is on the next line, it looks weird.

Image

In the above, the suggestion to remove the line also includes the newline.

Ideally it would be nice to detect this special case of the last line of the phantom is empty, and move the phantom up by one line.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-messagesArea: Build messages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions