Preserve tmpdir world-writable guard

Author: ioquatix

lib/tmpdir.rb

@@ -32,20 +32,18 @@ def self.tmpdir
       case
       when !stat.directory?
         warn "#{name} is not a directory: #{dir}"
+      when stat.world_writable? && !stat.sticky?
+        warn "#{name} is world-writable: #{dir}"
       when !File.writable?(dir)
         # We call File.writable?, not stat.writable?, because you can't tell if a dir is actually
         # writable just from stat; OS mechanisms other than user/group/world bits can affect this.
         #
-        # However, in some container environments (e.g. Kubernetes with read-only root filesystem
-        # and emptyDir volumes), File.writable? may return false even though the directory is
-        # actually writable via mounted volumes. Fall back to stat.writable? in that case.
+        # However, File.writable? can be a false negative, so fall back to stat.writable?.
         if stat.writable?
           warn "#{name}: File.writable? reports not writable but file mode bits suggest writable, using anyway: #{dir}"
           break dir
         end
         warn "#{name} is not writable: #{dir}"
-      when stat.world_writable? && !stat.sticky?
-        warn "#{name} is world-writable: #{dir}"
       else
         break dir
       end

test/test_tmpdir.rb

@@ -90,9 +90,26 @@ def test_writable_fallback_to_stat
     end
   end
 
+  def test_tmpdir_rejects_world_writable_non_sticky_before_writability
+    omit "no meaning on this platform" if /mswin|mingw/ =~ RUBY_PLATFORM
+    Dir.mktmpdir do |tmpdir|
+      envs = %w[TMPDIR TMP TEMP]
+      oldenv = envs.each_with_object({}) {|v, h| h[v] = ENV.delete(v)}
+      begin
+        ENV[envs[0]] = tmpdir
+        File.chmod(0777, tmpdir)
+
+        assert_not_equal(tmpdir, assert_warn(/is world-writable/) { Dir.tmpdir })
+      ensure
+        File.chmod(0755, tmpdir)
+        ENV.update(oldenv)
+      end
+    end
+  end
+
   def test_writable_fallback_both_fail
     omit "no meaning on this platform" if /mswin|mingw/ =~ RUBY_PLATFORM
-    omit "root can write to any directory" if Process.uid == 0
+    omit "root can write to any directory" if Process.euid == 0
     Dir.mktmpdir do |tmpdir|
       envs = %w[TMPDIR TMP TEMP]
       oldenv = envs.each_with_object({}) {|v, h| h[v] = ENV.delete(v)}