From 8b3dead6982ab091222bbbfd780326694cac3606 Mon Sep 17 00:00:00 2001 From: Aditya Singh Date: Fri, 23 Oct 2026 18:11:10 +0530 Subject: [PATCH 1/4] fix(deps): require patched Node for CVE-2026-111497 Node.js 22.23.4, 24.22.1 and 26.12.1 fix CVE-2026-111497, a high-severity out-of-bounds write in the Brotli decoder. Raise .nvmrc (which the shared CI workflows read) and the engines floor so earlier, affected releases warn on install. Ref: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases --- .nvmrc | 2 +- docs/getting-started.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.nvmrc b/.nvmrc index db49bb14..b8b23ca9 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -22.22.2 +22.23.4 diff --git a/docs/getting-started.md b/docs/getting-started.md index 2c2dacbc..a422c165 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -31,7 +31,7 @@ git clone https://github.com/rtCamp/theme-elementary.git acme-blog cd acme-blog ``` -The theme's install hook runs `npm i` during `create-project`, so have Node 22.22.2 or later active first. The first commit gives the Composer copy a baseline, so `git status` shows what init changes in step 3. +The theme's install hook runs `npm i` during `create-project`, so have Node 22.23.4 or later active first. The first commit gives the Composer copy a baseline, so `git status` shows what init changes in step 3. With `nvm`, select the project's Node version: diff --git a/package-lock.json b/package-lock.json index 0c1bf415..596f8370 100644 --- a/package-lock.json +++ b/package-lock.json @@ -44,7 +44,7 @@ "webpack-remove-empty-scripts": "1.1.1" }, "engines": { - "node": "^22.22.2 || ^24.15.0 || >=26.0.0" + "node": "^22.23.4 || ^24.22.1 || >=26.12.1" } }, "node_modules/@asamuzakjp/css-color": { diff --git a/package.json b/package.json index 6954509d..6dc25126 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "url": "https://github.com/rtCamp/theme-elementary/issues" }, "engines": { - "node": "^22.22.2 || ^24.15.0 || >=26.0.0" + "node": "^22.23.4 || ^24.22.1 || >=26.12.1" }, "dependencies": { "@wordpress/interactivity": "6.56.0" From 3abb8f4566b94bf4c926ab768e559a22399cb939 Mon Sep 17 00:00:00 2001 From: Aditya Singh Date: Fri, 23 Oct 2026 18:39:26 +0530 Subject: [PATCH 2/4] fix(deps): refuse installs on Node below the engines floor npm treats engines as advisory, so an affected Node only got an EBADENGINE warning. engine-strict makes npm ci / npm i (including Composer's npm i hook) fail instead. Patched 22.23.4 and 24.22.1 still install cleanly. --- .npmrc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.npmrc b/.npmrc index 1f486ec1..537399f5 100644 --- a/.npmrc +++ b/.npmrc @@ -2,3 +2,7 @@ save-exact = true ; The @rtcamp packages are public on the npm registry, so no scope registry or ; token is needed. + +; Fail the install, instead of only warning, on a Node outside package.json +; engines, so releases affected by CVE-2026-111497 are refused. +engine-strict = true From 427e188c80c57650b046f9a06921c5893460e040 Mon Sep 17 00:00:00 2001 From: Aditya Singh Date: Fri, 23 Oct 2026 19:45:50 +0530 Subject: [PATCH 3/4] revert(deps): drop engine-strict, keep engines advisory engine-strict turned the engines floor into a hard install failure. Node here only runs dev tooling (build, lint, tests, wp-env), so CVE-2026-111497 exposure is minimal, and the security ask is the .nvmrc and engines bump, not enforcement. engine-strict also failed CI, since the shared wp-ci@v1 installs the runner-cached Node 22.23.3 instead of reading .nvmrc (rtCamp/wp-shared-workflows#47). Affected releases still get an npm EBADENGINE warning. This reverts commit 3abb8f4. Co-Authored-By: Claude Opus 5.5 --- .npmrc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.npmrc b/.npmrc index 537399f5..1f486ec1 100644 --- a/.npmrc +++ b/.npmrc @@ -2,7 +2,3 @@ save-exact = true ; The @rtcamp packages are public on the npm registry, so no scope registry or ; token is needed. - -; Fail the install, instead of only warning, on a Node outside package.json -; engines, so releases affected by CVE-2026-111497 are refused. -engine-strict = true From 1f18997f878c3895017c06e2ba7e6408a65a540d Mon Sep 17 00:00:00 2001 From: Aditya Singh Date: Fri, 23 Oct 2026 19:47:04 +0530 Subject: [PATCH 4/4] docs: name each patched Node line in the setup requirements "22.23.4 or later" read as if any newer Node were fine, but 24.21.0 is newer and still affected, and engines rejects it. Co-Authored-By: Claude Opus 5.5 --- docs/getting-started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-started.md b/docs/getting-started.md index a422c165..25bbf0c7 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -31,7 +31,7 @@ git clone https://github.com/rtCamp/theme-elementary.git acme-blog cd acme-blog ``` -The theme's install hook runs `npm i` during `create-project`, so have Node 22.23.4 or later active first. The first commit gives the Composer copy a baseline, so `git status` shows what init changes in step 3. +The theme's install hook runs `npm i` during `create-project`, so have Node 22.23.4 (or 24.22.1+ / 26.12.1+) active first. The first commit gives the Composer copy a baseline, so `git status` shows what init changes in step 3. With `nvm`, select the project's Node version: