Skip to content

support for config files that don't use default #13

@alex-gable

Description

@alex-gable

Given that there isn't a global standard for yml file structures, this should not be a dependency for reading a config file.

I'd suggest replacing line 58 with default_config <- config_yaml[[config]] to have it check for the presence of the specified config, in the case that R_CONFIG_ACTIVE is specified as a value other than default or that a user specifies a config in the function call.

While this would work, I think re-writing that block to more specifically check for config as defined in the function call "default" or otherwise, as this step pretty intently looks strictly for "default".

Also, the documentation specifies R_CONFIG_NAME as the environment variable. It looks like this feature was not fully implemented in @jjallaire's branch.

Happy to (attempt) to make this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions