From b1727068ed599fc3a966b2147ba3e78ed3aec3a4 Mon Sep 17 00:00:00 2001 From: Michael Hall Date: Thu, 2 Apr 2026 13:58:09 +1000 Subject: [PATCH] fix: avoid compiler overflow in table fields parsing This prevents a trait evaluation overflow (E0275) when compiling against older macOS SDKs, such as those used in Bioconda CI, where the compiler struggles to infer the `IntoIterator` implementation. See https://github.com/bioconda/bioconda-recipes/pull/62357 --- src/table.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/table.rs b/src/table.rs index 6a9fd8d..fceca91 100644 --- a/src/table.rs +++ b/src/table.rs @@ -43,7 +43,7 @@ fn check_settings(autocycler_dir: &Option, sigfigs: usize) { fn parse_fields(comma_delimited_fields: String) -> Vec { - let fields = comma_delimited_fields.replace(" ", "").split(',') + let fields: Vec = comma_delimited_fields.replace(" ", "").split(',') .map(|s| s.to_string()).collect(); let mut valid_fields = HashSet::new(); valid_fields.extend(SubsampleMetrics::get_field_names()); @@ -52,7 +52,7 @@ fn parse_fields(comma_delimited_fields: String) -> Vec { valid_fields.extend(CombineMetrics::get_field_names()); valid_fields.extend(UntrimmedClusterMetrics::get_field_names()); valid_fields.extend(TrimmedClusterMetrics::get_field_names()); - for field in &fields { + for field in fields.iter() { if !valid_fields.contains(field) { quit_with_error(&format!("{field} is not a valid field name")); }