From 8b530d375880752f2948fe00da13ff35b9c93113 Mon Sep 17 00:00:00 2001 From: Scott Walkinshaw Date: Wed, 5 Aug 2026 19:38:25 -0400 Subject: [PATCH] Adds `redis` tags to fix package issue Fixes #1683 Using `--tags redis` would filter the `include_vars` out and not import the PHP version specific vars leading to an undefined variable for `redis_packages_default` etc. This fixes that by adding the `redis` tag (just like `memcached` and `php`) to the common task. --- roles/common/tasks/main.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/roles/common/tasks/main.yml b/roles/common/tasks/main.yml index 2c1a3e25a..53ad1bb9c 100644 --- a/roles/common/tasks/main.yml +++ b/roles/common/tasks/main.yml @@ -24,7 +24,7 @@ paths: - "{{ playbook_dir }}/roles/php/vars/" - tags: [memcached, php, sshd] + tags: [memcached, php, redis, sshd] - name: Verify dict format for package component variables fail: @@ -38,10 +38,12 @@ memcached_packages_custom: "{{ memcached_packages_custom }}" php_extensions_default: "{{ php_extensions_default }}" php_extensions_custom: "{{ php_extensions_custom }}" + redis_packages_default: "{{ redis_packages_default }}" + redis_packages_custom: "{{ redis_packages_custom }}" sshd_packages_default: "{{ sshd_packages_default }}" sshd_packages_custom: "{{ sshd_packages_custom }}" package_vars_wrong_format: "{{ package_vars | dict2items | rejectattr('value', 'mapping') | map(attribute='key') | list }}" - tags: [memcached, php, sshd] + tags: [memcached, php, redis, sshd] - name: Verify dict format for package combined variables fail: @@ -52,9 +54,10 @@ apt_packages: "{{ apt_packages }}" memcached_packages: "{{ memcached_packages }}" php_extensions: "{{ php_extensions }}" + redis_packages: "{{ redis_packages }}" sshd_packages: "{{ sshd_packages }}" package_vars_wrong_format: "{{ package_vars | dict2items | rejectattr('value', 'mapping') | map(attribute='key') | list }}" - tags: [memcached, php, sshd] + tags: [memcached, php, redis, sshd] - name: Clean old APT sources import_tasks: clean-apt-sources.yml