Nested creates doesnt throw meaningful error

[krishna-404]

I had duplicate primary-key in the nested creates & this was throwing error. Would be helpful to have actual error message. Thanks!

Error: duplicate key value violates unique constraint "product_variants_pkey"
(37.2ms) ROLLBACK

[07:02:06] ERROR: OpenAPI error 
    err: {
      "type": "",
      "message": "savepoint \"undefined\" does not exist: ",
      "stack":
          error: savepoint "undefined" does not exist
              at then (/Users/krishna404/codeProjects/teziapp/tezi-new-orpc/node_modules/pqb/src/query/then/then.ts:798:17)
              at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
          caused by: Error
              at Module.<anonymous> (/Users/krishna404/codeProjects/teziapp/tezi-new-orpc/node_modules/pqb/src/query/query-methods.ts:1036:1)
              at Module._compile (node:internal/modules/cjs/loader:1730:14)
              at Object.transformer (/Users/krishna404/codeProjects/teziapp/tezi-new-orpc/node_modules/tsx/dist/register-D46fvsV_.cjs:3:1104)
              at Module.load (node:internal/modules/cjs/loader:1465:32)
              at Function._load (node:internal/modules/cjs/loader:1282:12)
              at TracingChannel.traceSync (node:diagnostics_channel:322:14)
              at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
              at Module.<anonymous> (node:internal/modules/cjs/loader:1487:12)
      "length": 99,
      "name": "error",
      "severity": "ERROR",
      "code": "3B001",
      "file": "xact.c",
      "line": "4595",
      "routine": "RollbackToSavepoint"
    }

[krishna-404]

RCA from LLMs.

Root Cause Analysis

The issue is not that the client-side code is generating duplicate ULIDs. As seen in the request logs, the variant ULIDs are distinct (e.g. 01KSM3V53TH3AZH37YDFQEM7EW, 01KSM3V53T00KK8H0HHNRT2ASJ, etc.), since the client uses a secure random suffix generator for each iteration.

Instead, the duplicate insert is triggered by a query builder state pollution bug in Orchid ORM on the backend. When the backend chains .select() (containing relation subqueries) with .create() (containing nested inserts of those same relations), Orchid ORM generates two queries:

1. An insert query that writes both the product and its variants.
2. A select query to fetch the newly created product and its relations. Because the query builder state of the relation subquery carries over the creation payload context, Orchid ORM incorrectly appends a second CTE INSERT clause into the select query, trying to insert the exact same variants again.

Solution & Changes

To fix this, we need to separate the creation logic from the retrieval logic by running .create() in a clean query, and then fetching the product with its relations using .select().find(id) inside a transaction.

[romeerez]

I'm closing it for now because you didn't provide a reproduction, so I can't find a root cause, and can't confirm if it is fixed.

Just a moment ago I published a fix related to savepoints, and the error message here tells that the problem is related to savepoints:

"savepoint \"undefined\" does not exist: "

So there is a good chance this problem is fixed in the latest version, let me know if whether the problem is solved with the update.