From bd89c1a57d330c7cce07755f83769f6f82972887 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Tue, 10 Nov 2026 17:24:58 +0530 Subject: [PATCH 1/5] fix(memory): hold the remember lock on every memory delete path Governance delete, evict (TTL and old non-latest), auto-forget TTL and retention eviction deleted memory records without the mem:remember lock that remember, evolve and forget hold. A delete that landed between an evolve's read and its write was undone when evolve wrote the record back. Each path now re-reads the record under the lock and deletes it there, skipping records another writer already removed. The lock is taken per memory, so a long sweep does not block remember. withReentrantKeyedLock runs the body directly when the caller already holds the key. Fixes #1728 --- src/functions/auto-forget.ts | 11 +- src/functions/evict.ts | 5 +- src/functions/governance.ts | 5 +- src/functions/retention.ts | 11 +- src/state/keyed-mutex.ts | 4 + src/state/memory-utils.ts | 16 +++ test/memory-delete-lock.test.ts | 186 ++++++++++++++++++++++++++++++++ 7 files changed, 225 insertions(+), 13 deletions(-) create mode 100644 test/memory-delete-lock.test.ts diff --git a/src/functions/auto-forget.ts b/src/functions/auto-forget.ts index b9d2fcb44f..5c96252cbe 100644 --- a/src/functions/auto-forget.ts +++ b/src/functions/auto-forget.ts @@ -3,7 +3,7 @@ import { markCaptureEventDeleted } from "../capture/event-record.js"; import type { Memory, CompressedObservation, Session } from "../types.js"; import { KV } from "../state/schema.js"; import { StateKV, collectAll } from "../state/kv.js"; -import { supersededAt } from "../state/memory-utils.js"; +import { deleteMemoryUnderLock, supersededAt } from "../state/memory-utils.js"; import { withKeyedLock } from "../state/keyed-mutex.js"; import { unindexObservationSession } from "../state/obs-index.js"; import { recordAudit } from "./audit.js"; @@ -51,10 +51,11 @@ export function registerAutoForgetFunction(sdk: IIIClient, kv: StateKV): void { result.ttlExpired.push(mem.id); deletedIds.add(mem.id); if (!dryRun) { - if (mem.imageRef) { - await decrementImageRef(kv, sdk, mem.imageRef); - } - await kv.delete(KV.memories, mem.id); + const imageRef = mem.imageRef; + const removed = await deleteMemoryUnderLock(kv, KV.memories, mem.id, imageRef + ? () => decrementImageRef(kv, sdk, imageRef) + : undefined); + if (!removed) continue; facetIds.add(mem.id); await recordAudit(kv, "delete", "mem::auto-forget", [mem.id], { resource: "memory", diff --git a/src/functions/evict.ts b/src/functions/evict.ts index 33600d3cb0..1ca13aaf2b 100644 --- a/src/functions/evict.ts +++ b/src/functions/evict.ts @@ -10,6 +10,7 @@ import type { import { KV } from "../state/schema.js"; import { StateKV, collectAll } from "../state/kv.js"; import { withKeyedLock } from "../state/keyed-mutex.js"; +import { deleteMemoryUnderLock } from "../state/memory-utils.js"; import { removeSessionFromProjectIndex } from "../state/session-index.js"; import { unindexObservationSession } from "../state/obs-index.js"; import { isConsolidationEnabled } from "../config.js"; @@ -345,7 +346,7 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { evictedMemIds.add(mem.id); } else { try { - await kv.delete(KV.memories, mem.id); + if (!(await deleteMemoryUnderLock(kv, KV.memories, mem.id))) continue; deletedMemIds.add(mem.id); stats.expiredMemories++; evictedMemIds.add(mem.id); @@ -385,7 +386,7 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { stats.nonLatestMemories++; } else { try { - await kv.delete(KV.memories, mem.id); + if (!(await deleteMemoryUnderLock(kv, KV.memories, mem.id))) continue; deletedMemIds.add(mem.id); stats.nonLatestMemories++; } catch (err) { diff --git a/src/functions/governance.ts b/src/functions/governance.ts index 41ac200c62..e6b123f536 100644 --- a/src/functions/governance.ts +++ b/src/functions/governance.ts @@ -3,6 +3,7 @@ import type { Memory, GovernanceFilter, AuditEntry } from "../types.js"; import { KV } from "../state/schema.js"; import type { StateKV } from "../state/kv.js"; import { collectAll } from "../state/kv.js"; +import { deleteMemoryUnderLock } from "../state/memory-utils.js"; import { recordAudit, safeAudit, queryAudit } from "./audit.js"; import { deleteAccessLog } from "./access-tracker.js"; import { deleteFacetsForTargets } from "./facets.js"; @@ -21,9 +22,7 @@ async function deleteMemoryRecord( kv: StateKV, id: string, ): Promise<"deleted" | "missing"> { - const mem = await kv.get(KV.memories, id); - if (!mem) return "missing"; - await kv.delete(KV.memories, id); + if (!(await deleteMemoryUnderLock(kv, KV.memories, id))) return "missing"; await deleteAccessLog(kv, id); getSearchIndex().remove(id); vectorIndexRemove(id); diff --git a/src/functions/retention.ts b/src/functions/retention.ts index 97c05db910..7b269b4b79 100644 --- a/src/functions/retention.ts +++ b/src/functions/retention.ts @@ -8,6 +8,7 @@ import type { import { KV } from "../state/schema.js"; import type { StateKV } from "../state/kv.js"; import { collectAll } from "../state/kv.js"; +import { deleteMemoryUnderLock } from "../state/memory-utils.js"; import type { AccessLog } from "./access-tracker.js"; import { emptyAccessLog, @@ -373,10 +374,14 @@ export function registerRetentionFunctions( continue; } - if (mem.imageRef) { - await decrementImageRef(kv, sdk, mem.imageRef); + const imageRef = mem.imageRef; + const removed = await deleteMemoryUnderLock(kv, scope, candidate.memoryId, imageRef + ? () => decrementImageRef(kv, sdk, imageRef) + : undefined); + if (!removed) { + missingIds.push(candidate.memoryId); + continue; } - await kv.delete(scope, candidate.memoryId); evictedIds.push(candidate.memoryId); evicted++; if (resolvedSource === "semantic") evictedSemantic++; diff --git a/src/state/keyed-mutex.ts b/src/state/keyed-mutex.ts index 6ac2ac6ad7..308a5e7282 100644 --- a/src/state/keyed-mutex.ts +++ b/src/state/keyed-mutex.ts @@ -58,6 +58,10 @@ export function withKeyedLock( ); } +export function withReentrantKeyedLock(key: string, fn: () => Promise): Promise { + return isKeyedLockHeld(key) ? fn() : withKeyedLock(key, fn); +} + export function withKeyedLocks(keys: string[], fn: () => Promise): Promise { const ordered = [...new Set(keys)].sort(); const acquire = (index: number): Promise => index === ordered.length diff --git a/src/state/memory-utils.ts b/src/state/memory-utils.ts index 8c7cbe329e..c1eb2bec84 100644 --- a/src/state/memory-utils.ts +++ b/src/state/memory-utils.ts @@ -1,7 +1,23 @@ import type { CompressedObservation, Lesson, Memory } from "../types.js"; +import type { StateKV } from "./kv.js"; +import { withReentrantKeyedLock } from "./keyed-mutex.js"; const MAX_DATE_MS = 8.64e15; +export function deleteMemoryUnderLock( + kv: StateKV, + scope: string, + id: string, + beforeDelete?: () => Promise, +): Promise { + return withReentrantKeyedLock("mem:remember", async () => { + if (!(await kv.get(scope, id))) return false; + if (beforeDelete) await beforeDelete(); + await kv.delete(scope, id); + return true; + }); +} + export function supersededAt(previous: string | undefined, now: string): string { const prior = previous ? Date.parse(previous) : Number.NaN; const current = Date.parse(now); diff --git a/test/memory-delete-lock.test.ts b/test/memory-delete-lock.test.ts new file mode 100644 index 0000000000..f774a829e9 --- /dev/null +++ b/test/memory-delete-lock.test.ts @@ -0,0 +1,186 @@ +import { describe, it, expect, vi } from "vitest"; + +vi.mock("../src/logger.js", () => ({ + logger: { info: vi.fn(), warn: vi.fn(), error: vi.fn() }, +})); + +vi.mock("../src/config.js", async (importOriginal) => ({ + ...(await importOriginal()), + isConsolidationEnabled: () => false, +})); + +import { registerGovernanceFunction } from "../src/functions/governance.js"; +import { registerRelationsFunction } from "../src/functions/relations.js"; +import { registerEvictFunction } from "../src/functions/evict.js"; +import { registerAutoForgetFunction } from "../src/functions/auto-forget.js"; +import { withKeyedLock } from "../src/state/keyed-mutex.js"; +import { KV } from "../src/state/schema.js"; +import type { Memory } from "../src/types.js"; + +type Gate = { scope: string; key: string; reached: () => void; release: Promise }; + +function mockKV() { + const store = new Map>(); + let gate: Gate | null = null; + return { + store, + gateNextSet(scope: string, key: string) { + let reached!: () => void; + let release!: () => void; + const reachedPromise = new Promise((resolve) => { reached = resolve; }); + const releasePromise = new Promise((resolve) => { release = resolve; }); + gate = { scope, key, reached, release: releasePromise }; + return { reached: reachedPromise, release }; + }, + get: async (scope: string, key: string): Promise => + (store.get(scope)?.get(key) as T) ?? null, + set: async (scope: string, key: string, data: T): Promise => { + if (gate && gate.scope === scope && gate.key === key) { + const current = gate; + gate = null; + current.reached(); + await current.release; + } + if (!store.has(scope)) store.set(scope, new Map()); + store.get(scope)!.set(key, data); + return data; + }, + delete: async (scope: string, key: string): Promise => { + store.get(scope)?.delete(key); + }, + list: async (scope: string): Promise => { + const entries = store.get(scope); + return entries ? (Array.from(entries.values()) as T[]) : []; + }, + }; +} + +function mockSdk() { + const functions = new Map(); + return { + registerFunction: (idOrOpts: string | { id: string }, handler: Function) => { + const id = typeof idOrOpts === "string" ? idOrOpts : idOrOpts.id; + functions.set(id, handler); + }, + registerTrigger: () => {}, + trigger: async (idOrInput: string | { function_id: string; payload: unknown }, data?: unknown) => { + const id = typeof idOrInput === "string" ? idOrInput : idOrInput.function_id; + const payload = typeof idOrInput === "string" ? data : idOrInput.payload; + const fn = functions.get(id); + if (!fn) return { success: true }; + return fn(payload); + }, + }; +} + +function makeMemory(id: string, overrides: Partial = {}): Memory { + return { + id, + createdAt: "2026-02-01T00:00:00Z", + updatedAt: "2026-02-01T00:00:00Z", + type: "fact", + title: `Memory ${id}`, + content: `Content for ${id}`, + concepts: [], + files: [], + sessionIds: [], + strength: 5, + version: 1, + isLatest: true, + ...overrides, + }; +} + +async function holdRememberLockAndRewrite(kv: ReturnType, id: string) { + let reached!: () => void; + let release!: () => void; + const reachedPromise = new Promise((resolve) => { reached = resolve; }); + const releasePromise = new Promise((resolve) => { release = resolve; }); + const done = withKeyedLock("mem:remember", async () => { + const current = await kv.get(KV.memories, id); + reached(); + await releasePromise; + if (current) await kv.set(KV.memories, id, { ...current, isLatest: false }); + }); + await reachedPromise; + return { release, done }; +} + +describe("memory delete paths hold the remember lock", () => { + it("governance delete waits for an in-flight evolve and the memory stays deleted", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerGovernanceFunction(sdk as never, kv as never); + registerRelationsFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_x", makeMemory("mem_x")); + + const gate = kv.gateNextSet(KV.memories, "mem_x"); + const evolve = sdk.trigger("mem::evolve", { memoryId: "mem_x", newContent: "updated content" }); + await gate.reached; + + const deletion = sdk.trigger("mem::governance-delete", { memoryIds: ["mem_x"] }); + await new Promise((resolve) => setTimeout(resolve, 10)); + expect(await kv.get(KV.memories, "mem_x")).not.toBeNull(); + + gate.release(); + await evolve; + const result = (await deletion) as { deleted: number }; + + expect(result.deleted).toBe(1); + expect(await kv.get(KV.memories, "mem_x")).toBeNull(); + }); + + it("evict TTL delete waits for the lock holder and does not get undone", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerEvictFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_ttl", makeMemory("mem_ttl", { forgetAfter: "2020-01-01T00:00:00Z" })); + + const holder = await holdRememberLockAndRewrite(kv, "mem_ttl"); + const evict = sdk.trigger("mem::evict", {}); + await new Promise((resolve) => setTimeout(resolve, 10)); + expect(await kv.get(KV.memories, "mem_ttl")).not.toBeNull(); + + holder.release(); + await holder.done; + const result = (await evict) as { expiredMemories: number }; + + expect(result.expiredMemories).toBe(1); + expect(await kv.get(KV.memories, "mem_ttl")).toBeNull(); + }); + + it("evict skips a memory that another writer already deleted", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerEvictFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_gone", makeMemory("mem_gone", { forgetAfter: "2020-01-01T00:00:00Z" })); + + const done = withKeyedLock("mem:remember", async () => { + await new Promise((resolve) => setTimeout(resolve, 10)); + await kv.delete(KV.memories, "mem_gone"); + }); + const result = (await sdk.trigger("mem::evict", {})) as { expiredMemories: number }; + await done; + + expect(result.expiredMemories).toBe(0); + }); + + it("auto-forget TTL delete waits for the lock holder and does not get undone", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerAutoForgetFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_af", makeMemory("mem_af", { forgetAfter: "2020-01-01T00:00:00Z" })); + + const holder = await holdRememberLockAndRewrite(kv, "mem_af"); + const run = sdk.trigger("mem::auto-forget", {}); + await new Promise((resolve) => setTimeout(resolve, 10)); + expect(await kv.get(KV.memories, "mem_af")).not.toBeNull(); + + holder.release(); + await holder.done; + const result = (await run) as { ttlExpired: string[] }; + + expect(result.ttlExpired).toEqual(["mem_af"]); + expect(await kv.get(KV.memories, "mem_af")).toBeNull(); + }); +}); From 13a32eaeeec615e3bccc528bc9b984cfdd754f0a Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Wed, 11 Nov 2026 12:13:06 +0530 Subject: [PATCH 2/5] fix(memory): release images outside the remember lock and drop orphan retention scores deleteMemoryUnderLock now returns the record it read and deleted under mem:remember. Auto-forget and retention release that record's image after the lock is released, so image I/O no longer serializes every memory write and a record replaced while the sweep waited releases its own image instead of the stale one. Retention eviction deletes the score of a candidate that is gone from both memory scopes, so a memory forgotten while the sweep waited no longer holds a maxEvict slot on every later run. A score whose memory still lives in the other scope is kept. Adds retention eviction race, orphan score and image release tests. --- src/functions/auto-forget.ts | 6 +- src/functions/retention.ts | 10 +-- src/state/memory-utils.ts | 11 ++- test/memory-delete-lock.test.ts | 117 +++++++++++++++++++++++++++++++- 4 files changed, 129 insertions(+), 15 deletions(-) diff --git a/src/functions/auto-forget.ts b/src/functions/auto-forget.ts index c3be88314e..7fd19fe16c 100644 --- a/src/functions/auto-forget.ts +++ b/src/functions/auto-forget.ts @@ -51,11 +51,9 @@ export function registerAutoForgetFunction(sdk: IIIClient, kv: StateKV): void { result.ttlExpired.push(mem.id); deletedIds.add(mem.id); if (!dryRun) { - const imageRef = mem.imageRef; - const removed = await deleteMemoryUnderLock(kv, KV.memories, mem.id, imageRef - ? () => decrementImageRef(kv, sdk, imageRef) - : undefined); + const removed = await deleteMemoryUnderLock(kv, KV.memories, mem.id); if (!removed) continue; + if (removed.imageRef) await decrementImageRef(kv, sdk, removed.imageRef); facetIds.add(mem.id); await recordAudit(kv, "delete", "mem::auto-forget", [mem.id], { resource: "memory", diff --git a/src/functions/retention.ts b/src/functions/retention.ts index 7b269b4b79..66167f1d4a 100644 --- a/src/functions/retention.ts +++ b/src/functions/retention.ts @@ -374,14 +374,12 @@ export function registerRetentionFunctions( continue; } - const imageRef = mem.imageRef; - const removed = await deleteMemoryUnderLock(kv, scope, candidate.memoryId, imageRef - ? () => decrementImageRef(kv, sdk, imageRef) - : undefined); + const removed = await deleteMemoryUnderLock(kv, scope, candidate.memoryId); if (!removed) { missingIds.push(candidate.memoryId); continue; } + if (removed.imageRef) await decrementImageRef(kv, sdk, removed.imageRef); evictedIds.push(candidate.memoryId); evicted++; if (resolvedSource === "semantic") evictedSemantic++; @@ -395,6 +393,10 @@ export function registerRetentionFunctions( } } + for (const id of missingIds) { + if (await kv.get(KV.memories, id) || await kv.get(KV.semantic, id)) continue; + await kv.delete(KV.retentionScores, id); + } await deleteFacetsForTargets(kv, [...evictedIds, ...missingIds]); // Retention eviction is a structural delete path that removes diff --git a/src/state/memory-utils.ts b/src/state/memory-utils.ts index c1eb2bec84..86a463efa2 100644 --- a/src/state/memory-utils.ts +++ b/src/state/memory-utils.ts @@ -4,17 +4,16 @@ import { withReentrantKeyedLock } from "./keyed-mutex.js"; const MAX_DATE_MS = 8.64e15; -export function deleteMemoryUnderLock( +export function deleteMemoryUnderLock( kv: StateKV, scope: string, id: string, - beforeDelete?: () => Promise, -): Promise { +): Promise { return withReentrantKeyedLock("mem:remember", async () => { - if (!(await kv.get(scope, id))) return false; - if (beforeDelete) await beforeDelete(); + const current = await kv.get(scope, id); + if (!current) return null; await kv.delete(scope, id); - return true; + return current; }); } diff --git a/test/memory-delete-lock.test.ts b/test/memory-delete-lock.test.ts index f774a829e9..db81849e3e 100644 --- a/test/memory-delete-lock.test.ts +++ b/test/memory-delete-lock.test.ts @@ -9,13 +9,23 @@ vi.mock("../src/config.js", async (importOriginal) => ({ isConsolidationEnabled: () => false, })); +const imageReleases: Array<{ path: string; lockHeld: boolean }> = []; +vi.mock("../src/functions/image-refs.js", async (importOriginal) => ({ + ...(await importOriginal()), + decrementImageRef: vi.fn(async (_kv: unknown, _sdk: unknown, path: string) => { + const { isKeyedLockHeld } = await import("../src/state/keyed-mutex.js"); + imageReleases.push({ path, lockHeld: isKeyedLockHeld("mem:remember") }); + }), +})); + import { registerGovernanceFunction } from "../src/functions/governance.js"; import { registerRelationsFunction } from "../src/functions/relations.js"; import { registerEvictFunction } from "../src/functions/evict.js"; import { registerAutoForgetFunction } from "../src/functions/auto-forget.js"; +import { registerRetentionFunctions } from "../src/functions/retention.js"; import { withKeyedLock } from "../src/state/keyed-mutex.js"; import { KV } from "../src/state/schema.js"; -import type { Memory } from "../src/types.js"; +import type { Memory, RetentionScore } from "../src/types.js"; type Gate = { scope: string; key: string; reached: () => void; release: Promise }; @@ -183,4 +193,109 @@ describe("memory delete paths hold the remember lock", () => { expect(result.ttlExpired).toEqual(["mem_af"]); expect(await kv.get(KV.memories, "mem_af")).toBeNull(); }); + + it("auto-forget releases the image of the record it deleted, outside the remember lock", async () => { + imageReleases.length = 0; + const kv = mockKV(); + const sdk = mockSdk(); + registerAutoForgetFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_img", makeMemory("mem_img", { forgetAfter: "2020-01-01T00:00:00Z", imageRef: "old.png" })); + + let release!: () => void; + let reached!: () => void; + const reachedPromise = new Promise((resolve) => { reached = resolve; }); + const releasePromise = new Promise((resolve) => { release = resolve; }); + const holder = withKeyedLock("mem:remember", async () => { + reached(); + await releasePromise; + const current = await kv.get(KV.memories, "mem_img"); + await kv.set(KV.memories, "mem_img", { ...current!, imageRef: "new.png" }); + }); + await reachedPromise; + const run = sdk.trigger("mem::auto-forget", {}); + await new Promise((resolve) => setTimeout(resolve, 10)); + release(); + await holder; + await run; + + expect(await kv.get(KV.memories, "mem_img")).toBeNull(); + expect(imageReleases).toEqual([{ path: "new.png", lockHeld: false }]); + }); +}); + +function score(memoryId: string, value: number): RetentionScore { + return { + memoryId, + source: "episodic", + score: value, + salience: value, + temporalDecay: 1, + reinforcementBoost: 0, + lastAccessed: "2026-01-01T00:00:00Z", + accessCount: 0, + }; +} + +describe("retention eviction holds the remember lock", () => { + it("waits for the lock holder and the memory stays deleted", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerRetentionFunctions(sdk as never, kv as never); + await kv.set(KV.memories, "mem_ret", makeMemory("mem_ret")); + await kv.set(KV.retentionScores, "mem_ret", score("mem_ret", 0.01)); + + const holder = await holdRememberLockAndRewrite(kv, "mem_ret"); + const evict = sdk.trigger("mem::retention-evict", { threshold: 0.5 }); + await new Promise((resolve) => setTimeout(resolve, 10)); + expect(await kv.get(KV.memories, "mem_ret")).not.toBeNull(); + + holder.release(); + await holder.done; + const result = (await evict) as { evicted: number }; + + expect(result.evicted).toBe(1); + expect(await kv.get(KV.memories, "mem_ret")).toBeNull(); + }); + + it("drops the score of a memory deleted while eviction waited so it cannot hold a slot", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerRetentionFunctions(sdk as never, kv as never); + await kv.set(KV.memories, "mem_a", makeMemory("mem_a")); + await kv.set(KV.memories, "mem_b", makeMemory("mem_b")); + await kv.set(KV.retentionScores, "mem_a", score("mem_a", 0.01)); + await kv.set(KV.retentionScores, "mem_b", score("mem_b", 0.02)); + + const done = withKeyedLock("mem:remember", async () => { + await new Promise((resolve) => setTimeout(resolve, 10)); + await kv.delete(KV.memories, "mem_a"); + }); + const first = (await sdk.trigger("mem::retention-evict", { threshold: 0.5, maxEvict: 1 })) as { evicted: number }; + await done; + + expect(first.evicted).toBe(0); + expect(await kv.get(KV.retentionScores, "mem_a")).toBeNull(); + + const second = (await sdk.trigger("mem::retention-evict", { threshold: 0.5, maxEvict: 1 })) as { evicted: number }; + expect(second.evicted).toBe(1); + expect(await kv.get(KV.memories, "mem_b")).toBeNull(); + }); + + it("keeps the score when the memory still lives in the other scope", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerRetentionFunctions(sdk as never, kv as never); + await kv.set(KV.semantic, "mem_s", makeMemory("mem_s")); + await kv.set(KV.retentionScores, "mem_s", { ...score("mem_s", 0.01), source: undefined }); + + const done = withKeyedLock("mem:remember", async () => { + await new Promise((resolve) => setTimeout(resolve, 10)); + await kv.delete(KV.semantic, "mem_s"); + await kv.set(KV.memories, "mem_s", makeMemory("mem_s")); + }); + await sdk.trigger("mem::retention-evict", { threshold: 0.5, maxEvict: 1 }); + await done; + + expect(await kv.get(KV.retentionScores, "mem_s")).not.toBeNull(); + }); }); From 5eae7680da0fb201db7f5dd5aff3a0397de73609 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Wed, 11 Nov 2026 12:19:17 +0530 Subject: [PATCH 3/5] fix(retention): finish delete cleanup when an image release fails and audit orphan scores A rejected decrementImageRef after the locked delete skipped the score, access log and search cleanup in retention eviction and aborted the auto-forget TTL sweep. Release images through releaseImageRef, which logs the failure with the owning record id and lets the rest of the cleanup run. Removing retention scores for memories that no longer exist now records a mem::retention-evict audit entry even when nothing was evicted. --- AGENTS.md | 4 +- README.md | 4 +- READMEs/README.ar-SA.md | 4 +- READMEs/README.bn-BD.md | 4 +- READMEs/README.cs-CZ.md | 4 +- READMEs/README.da-DK.md | 4 +- READMEs/README.de-DE.md | 4 +- READMEs/README.el-GR.md | 4 +- READMEs/README.es-ES.md | 4 +- READMEs/README.fi-FI.md | 4 +- READMEs/README.fr-FR.md | 4 +- READMEs/README.he-IL.md | 4 +- READMEs/README.hi-IN.md | 4 +- READMEs/README.hu-HU.md | 4 +- READMEs/README.id-ID.md | 4 +- READMEs/README.it-IT.md | 4 +- READMEs/README.ja-JP.md | 4 +- READMEs/README.ko-KR.md | 4 +- READMEs/README.nb-NO.md | 4 +- READMEs/README.nl-NL.md | 4 +- READMEs/README.pl-PL.md | 4 +- READMEs/README.pt-BR.md | 4 +- READMEs/README.pt-PT.md | 4 +- READMEs/README.ro-RO.md | 4 +- READMEs/README.ru-RU.md | 4 +- READMEs/README.sv-SE.md | 4 +- READMEs/README.th-TH.md | 4 +- READMEs/README.tl-PH.md | 4 +- READMEs/README.tr-TR.md | 4 +- READMEs/README.uk-UA.md | 4 +- READMEs/README.ur-PK.md | 4 +- READMEs/README.vi-VN.md | 4 +- READMEs/README.zh-CN.md | 4 +- READMEs/README.zh-TW.md | 4 +- assets/tags/light/stat-tests.svg | 4 +- assets/tags/stat-tests.svg | 4 +- scripts/docs-sync.state.json | 2 +- src/functions/auto-forget.ts | 4 +- src/functions/image-refs.ts | 13 ++++++ src/functions/retention.ts | 13 +++++- test/memory-delete-lock.test.ts | 69 +++++++++++++++++++++++++++++--- 41 files changed, 163 insertions(+), 82 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 3897c7910e..81b4eed6fa 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -101,7 +101,7 @@ Hook scripts in `src/hooks/` are standalone Node.js scripts (no iii-sdk import). ## Testing -- Before every commit run, in order: `npm run build`, `npm run skills:gen`, `npm run docs:sync`, `npm run skills:check`, `npm test` (4,700+ tests). Commit anything the generators changed. CI runs the same build, skills check and tests. +- Before every commit run, in order: `npm run build`, `npm run skills:gen`, `npm run docs:sync`, `npm run skills:check`, `npm test` (4,800+ tests). Commit anything the generators changed. CI runs the same build, skills check and tests. - Before any npm publish: `npm run release:gate` must pass. It installs the packed tarballs into a clean home and runs capture, recovery, restart, export/import, MCP and status checks against the installed CLI (see CONTRIBUTING.md, Release process) - Mock pattern: `vi.mock("iii-sdk")` with mock `sdk.trigger`, `kv.get/set/list` - Test files go in `test/` with `.test.ts` extension @@ -114,4 +114,4 @@ Hook scripts in `src/hooks/` are standalone Node.js scripts (no iii-sdk import). - 6 MCP resources, 3 MCP prompts - 12 hooks, 17 skills - 322+ iii functions -- 4,700+ tests +- 4,800+ tests diff --git a/README.md b/README.md index cd40701a05..7590f939b8 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1313,7 +1313,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ar-SA.md b/READMEs/README.ar-SA.md index 19dfdad2f8..40b6c0699d 100644 --- a/READMEs/README.ar-SA.md +++ b/READMEs/README.ar-SA.md @@ -71,7 +71,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1244,7 +1244,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.bn-BD.md b/READMEs/README.bn-BD.md index a0881d0c27..b16b1f7bd4 100644 --- a/READMEs/README.bn-BD.md +++ b/READMEs/README.bn-BD.md @@ -69,7 +69,7 @@ 54 MCP টুল 12 অটো হুক 0 এক্সটার্নাল ডিবি - 4,700+ টেস্ট পাস + 4,800+ টেস্ট পাস

@@ -1257,7 +1257,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.cs-CZ.md b/READMEs/README.cs-CZ.md index 3837c5eb6e..41c98ab4df 100644 --- a/READMEs/README.cs-CZ.md +++ b/READMEs/README.cs-CZ.md @@ -69,7 +69,7 @@ 54 MCP nástrojů 12 automatických hooks 0 externích databází - 4,700+ testů úspěšně proběhlo + 4,800+ testů úspěšně proběhlo

@@ -1243,7 +1243,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.da-DK.md b/READMEs/README.da-DK.md index 209257de1f..6e96f1ad65 100644 --- a/READMEs/README.da-DK.md +++ b/READMEs/README.da-DK.md @@ -69,7 +69,7 @@ 54 MCP-værktøjer 12 automatiske hooks 0 eksterne databaser - 4,700+ beståede tests + 4,800+ beståede tests

@@ -1251,7 +1251,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.de-DE.md b/READMEs/README.de-DE.md index a0b4b683b8..f09b2211b6 100644 --- a/READMEs/README.de-DE.md +++ b/READMEs/README.de-DE.md @@ -69,7 +69,7 @@ 54 MCP-Tools 12 Auto-Hooks 0 externe DBs - 4,700+ bestandene Tests + 4,800+ bestandene Tests

@@ -1249,7 +1249,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.el-GR.md b/READMEs/README.el-GR.md index 49f0fb50b2..20190d727a 100644 --- a/READMEs/README.el-GR.md +++ b/READMEs/README.el-GR.md @@ -69,7 +69,7 @@ 54 εργαλεία MCP 12 αυτόματα hooks 0 εξωτερικές βάσεις δεδομένων - 4,700+ επιτυχημένες δοκιμές + 4,800+ επιτυχημένες δοκιμές

@@ -1243,7 +1243,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.es-ES.md b/READMEs/README.es-ES.md index 0cf25dab97..6ca88703a2 100644 --- a/READMEs/README.es-ES.md +++ b/READMEs/README.es-ES.md @@ -69,7 +69,7 @@ 54 tools MCP 12 hooks automáticos 0 bases de datos externas - 4,700+ tests superados + 4,800+ tests superados

@@ -1245,7 +1245,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.fi-FI.md b/READMEs/README.fi-FI.md index c580718e9f..c82e700071 100644 --- a/READMEs/README.fi-FI.md +++ b/READMEs/README.fi-FI.md @@ -69,7 +69,7 @@ 54 MCP-työkalua 12 automaattista hookia 0 ulkoista tietokantaa - 4,700+ testiä läpäisty + 4,800+ testiä läpäisty

@@ -1243,7 +1243,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.fr-FR.md b/READMEs/README.fr-FR.md index 3f508c8454..981e72e4f9 100644 --- a/READMEs/README.fr-FR.md +++ b/READMEs/README.fr-FR.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1252,7 +1252,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.he-IL.md b/READMEs/README.he-IL.md index 73f6e4a233..313f456302 100644 --- a/READMEs/README.he-IL.md +++ b/READMEs/README.he-IL.md @@ -71,7 +71,7 @@ 54 כלי MCP 12 hooks אוטומטיים 0 מסדי נתונים חיצוניים - 4,700+ בדיקות עוברות + 4,800+ בדיקות עוברות

@@ -1244,7 +1244,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.hi-IN.md b/READMEs/README.hi-IN.md index 4c3a8d31e2..9bed3ca5eb 100644 --- a/READMEs/README.hi-IN.md +++ b/READMEs/README.hi-IN.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1258,7 +1258,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.hu-HU.md b/READMEs/README.hu-HU.md index 20d0e86604..819b196d68 100644 --- a/READMEs/README.hu-HU.md +++ b/READMEs/README.hu-HU.md @@ -69,7 +69,7 @@ 54 MCP eszköz 12 automatikus hook 0 külső adatbázis - 4,700+ sikeres teszt + 4,800+ sikeres teszt

@@ -1241,7 +1241,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.id-ID.md b/READMEs/README.id-ID.md index 855cd4dd52..a5813dcfc8 100644 --- a/READMEs/README.id-ID.md +++ b/READMEs/README.id-ID.md @@ -69,7 +69,7 @@ 54 tool MCP 12 hook otomatis 0 DB eksternal - 4,700+ pengujian lolos + 4,800+ pengujian lolos

@@ -1258,7 +1258,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.it-IT.md b/READMEs/README.it-IT.md index cd396e06e9..a2e6f3aa8e 100644 --- a/READMEs/README.it-IT.md +++ b/READMEs/README.it-IT.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1251,7 +1251,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ja-JP.md b/READMEs/README.ja-JP.md index 9dfe1e726c..412d9f4224 100644 --- a/READMEs/README.ja-JP.md +++ b/READMEs/README.ja-JP.md @@ -69,7 +69,7 @@ 54 MCP ツール 12 自動 hooks 外部 DB 0 個 - 4,700+ 件のテストが成功 + 4,800+ 件のテストが成功

@@ -1257,7 +1257,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ko-KR.md b/READMEs/README.ko-KR.md index 4c77e312b0..db1bee6bd2 100644 --- a/READMEs/README.ko-KR.md +++ b/READMEs/README.ko-KR.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1256,7 +1256,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.nb-NO.md b/READMEs/README.nb-NO.md index e617bec5e1..def9fa24d0 100644 --- a/READMEs/README.nb-NO.md +++ b/READMEs/README.nb-NO.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1249,7 +1249,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.nl-NL.md b/READMEs/README.nl-NL.md index ab0aa4972b..a41ab0bf2e 100644 --- a/READMEs/README.nl-NL.md +++ b/READMEs/README.nl-NL.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1245,7 +1245,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.pl-PL.md b/READMEs/README.pl-PL.md index c24834e624..be1064ea75 100644 --- a/READMEs/README.pl-PL.md +++ b/READMEs/README.pl-PL.md @@ -69,7 +69,7 @@ 54 narzędzia MCP 12 automatycznych hooków 0 zewnętrznych baz danych - 4,700+ zaliczonych testów + 4,800+ zaliczonych testów

@@ -1241,7 +1241,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.pt-BR.md b/READMEs/README.pt-BR.md index 8cba9a4b83..14023e43ce 100644 --- a/READMEs/README.pt-BR.md +++ b/READMEs/README.pt-BR.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1249,7 +1249,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.pt-PT.md b/READMEs/README.pt-PT.md index c237b780d8..3f2e79bb91 100644 --- a/READMEs/README.pt-PT.md +++ b/READMEs/README.pt-PT.md @@ -69,7 +69,7 @@ 54 ferramentas MCP 12 hooks automáticos 0 bases de dados externas - 4,700+ testes aprovados + 4,800+ testes aprovados

@@ -1245,7 +1245,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ro-RO.md b/READMEs/README.ro-RO.md index 620d55913d..91d70e2ffe 100644 --- a/READMEs/README.ro-RO.md +++ b/READMEs/README.ro-RO.md @@ -69,7 +69,7 @@ 54 de instrumente MCP 12 hook-uri automate 0 baze de date externe - 4,700+ teste trecute + 4,800+ teste trecute

@@ -1237,7 +1237,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ru-RU.md b/READMEs/README.ru-RU.md index 3086998cdd..aed56590dc 100644 --- a/READMEs/README.ru-RU.md +++ b/READMEs/README.ru-RU.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1243,7 +1243,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.sv-SE.md b/READMEs/README.sv-SE.md index c29d00dbee..fc2f4d5b80 100644 --- a/READMEs/README.sv-SE.md +++ b/READMEs/README.sv-SE.md @@ -69,7 +69,7 @@ 54 MCP-verktyg 12 automatiska hooks 0 externa databaser - 4,700+ godkända tester + 4,800+ godkända tester

@@ -1251,7 +1251,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.th-TH.md b/READMEs/README.th-TH.md index 49a0e9ce46..fa1bd6d710 100644 --- a/READMEs/README.th-TH.md +++ b/READMEs/README.th-TH.md @@ -69,7 +69,7 @@ 54 เครื่องมือ MCP 12 hook อัตโนมัติ ไม่ต้องพึ่ง external DB เลย - ผ่านการทดสอบ 4,700+ รายการ + ผ่านการทดสอบ 4,800+ รายการ

@@ -1244,7 +1244,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.tl-PH.md b/READMEs/README.tl-PH.md index 9eacba7baf..27cec827c0 100644 --- a/READMEs/README.tl-PH.md +++ b/READMEs/README.tl-PH.md @@ -69,7 +69,7 @@ 54 MCP tool 12 awtomatikong hook 0 panlabas na DB - 4,700+ pumapasang test + 4,800+ pumapasang test

@@ -1253,7 +1253,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.tr-TR.md b/READMEs/README.tr-TR.md index f1aa62a40a..d26df964c2 100644 --- a/READMEs/README.tr-TR.md +++ b/READMEs/README.tr-TR.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1243,7 +1243,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.uk-UA.md b/READMEs/README.uk-UA.md index 11019c61fe..08832163f6 100644 --- a/READMEs/README.uk-UA.md +++ b/READMEs/README.uk-UA.md @@ -69,7 +69,7 @@ 54 інструменти MCP 12 автоматичних хуків 0 зовнішніх БД - 4,700+ тестів пройдено + 4,800+ тестів пройдено

@@ -1244,7 +1244,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.ur-PK.md b/READMEs/README.ur-PK.md index a4a9b37b3c..c61fdbc3ef 100644 --- a/READMEs/README.ur-PK.md +++ b/READMEs/README.ur-PK.md @@ -71,7 +71,7 @@ 54 MCP ٹولز 12 خودکار ہکس 0 خارجی ڈیٹابیسز - 4,700+ ٹیسٹس پاس ہو رہے ہیں + 4,800+ ٹیسٹس پاس ہو رہے ہیں

@@ -1248,7 +1248,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.vi-VN.md b/READMEs/README.vi-VN.md index 47177b4c47..6b3d54b63f 100644 --- a/READMEs/README.vi-VN.md +++ b/READMEs/README.vi-VN.md @@ -69,7 +69,7 @@ 54 MCP tools 12 auto hooks 0 external DBs - 4,700+ tests passing + 4,800+ tests passing

@@ -1253,7 +1253,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.zh-CN.md b/READMEs/README.zh-CN.md index 0a5f9c2d05..e7a3f90896 100644 --- a/READMEs/README.zh-CN.md +++ b/READMEs/README.zh-CN.md @@ -69,7 +69,7 @@ 54 个 MCP 工具 12 个自动 hooks 0 个外部数据库 - 4,700+ 项测试通过 + 4,800+ 项测试通过

@@ -1254,7 +1254,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/READMEs/README.zh-TW.md b/READMEs/README.zh-TW.md index c2e315c886..74e1eca426 100644 --- a/READMEs/README.zh-TW.md +++ b/READMEs/README.zh-TW.md @@ -69,7 +69,7 @@ 54 個 MCP 工具 12 個自動 hooks 0 個外部資料庫 - 4,700+ 測試通過 + 4,800+ 測試通過

@@ -1246,7 +1246,7 @@ curl -X POST http://localhost:3111/agentmemory/graph/compact -H "Authorization: ```bash npm run dev # Hot reload npm run build # Production build -npm test # 4,700+ tests +npm test # 4,800+ tests npm run test:integration # API tests (requires running services) ``` diff --git a/assets/tags/light/stat-tests.svg b/assets/tags/light/stat-tests.svg index 1b4179cfc2..743b0d095d 100644 --- a/assets/tags/light/stat-tests.svg +++ b/assets/tags/light/stat-tests.svg @@ -1,5 +1,5 @@ - + - 4700+ + 4800+ TESTS PASSING diff --git a/assets/tags/stat-tests.svg b/assets/tags/stat-tests.svg index 2b679ac742..7b4a1c20eb 100644 --- a/assets/tags/stat-tests.svg +++ b/assets/tags/stat-tests.svg @@ -1,5 +1,5 @@ - + - 4700+ + 4800+ TESTS PASSING diff --git a/scripts/docs-sync.state.json b/scripts/docs-sync.state.json index ef3f2b4c6b..6d5580a194 100644 --- a/scripts/docs-sync.state.json +++ b/scripts/docs-sync.state.json @@ -20,7 +20,7 @@ "12" ], "tests": [ - "4700+" + "4800+" ], "functions": [ "323" diff --git a/src/functions/auto-forget.ts b/src/functions/auto-forget.ts index 7fd19fe16c..42ee095fbd 100644 --- a/src/functions/auto-forget.ts +++ b/src/functions/auto-forget.ts @@ -31,7 +31,7 @@ export function registerAutoForgetFunction(sdk: IIIClient, kv: StateKV): void { async (data: { dryRun?: boolean }): Promise => { const dryRun = data?.dryRun ?? false; const now = Date.now(); - const { decrementImageRef } = await import("./image-refs.js"); + const { decrementImageRef, releaseImageRef } = await import("./image-refs.js"); const result: AutoForgetResult = { ttlExpired: [], @@ -53,7 +53,7 @@ export function registerAutoForgetFunction(sdk: IIIClient, kv: StateKV): void { if (!dryRun) { const removed = await deleteMemoryUnderLock(kv, KV.memories, mem.id); if (!removed) continue; - if (removed.imageRef) await decrementImageRef(kv, sdk, removed.imageRef); + if (removed.imageRef) await releaseImageRef(kv, sdk, mem.id, removed.imageRef); facetIds.add(mem.id); await recordAudit(kv, "delete", "mem::auto-forget", [mem.id], { resource: "memory", diff --git a/src/functions/image-refs.ts b/src/functions/image-refs.ts index 918a7e7c46..75012f0448 100644 --- a/src/functions/image-refs.ts +++ b/src/functions/image-refs.ts @@ -3,6 +3,7 @@ import { KV } from "../state/schema.js"; import { StateKV } from "../state/kv.js"; import { deleteImage, touchImage } from "../utils/image-store.js"; import { withKeyedLock } from "../state/keyed-mutex.js"; +import { logger } from "../logger.js"; export async function getImageRefCount(kv: StateKV, filePath: string): Promise { const count = await kv.get(KV.imageRefs, filePath); @@ -36,3 +37,15 @@ export async function decrementImageRef(kv: StateKV, sdk: IIIClient, filePath: s } }); } + +export async function releaseImageRef(kv: StateKV, sdk: IIIClient, ownerId: string, filePath: string): Promise { + try { + await decrementImageRef(kv, sdk, filePath); + } catch (err) { + logger.warn("Image reference release failed after delete", { + ownerId, + imageRef: filePath, + error: err instanceof Error ? err.message : String(err), + }); + } +} diff --git a/src/functions/retention.ts b/src/functions/retention.ts index 66167f1d4a..a40e5f4a78 100644 --- a/src/functions/retention.ts +++ b/src/functions/retention.ts @@ -307,7 +307,7 @@ export function registerRetentionFunctions( ? data.maxEvict : 50; const maxEvict = Math.min(1000, Math.max(0, maxEvictRaw)); - const { decrementImageRef } = await import("./image-refs.js"); + const { releaseImageRef } = await import("./image-refs.js"); const allScores = await kv.list(KV.retentionScores); const candidates = allScores @@ -379,7 +379,7 @@ export function registerRetentionFunctions( missingIds.push(candidate.memoryId); continue; } - if (removed.imageRef) await decrementImageRef(kv, sdk, removed.imageRef); + if (removed.imageRef) await releaseImageRef(kv, sdk, candidate.memoryId, removed.imageRef); evictedIds.push(candidate.memoryId); evicted++; if (resolvedSource === "semantic") evictedSemantic++; @@ -393,9 +393,11 @@ export function registerRetentionFunctions( } } + const orphanScoreIds: string[] = []; for (const id of missingIds) { if (await kv.get(KV.memories, id) || await kv.get(KV.semantic, id)) continue; await kv.delete(KV.retentionScores, id); + orphanScoreIds.push(id); } await deleteFacetsForTargets(kv, [...evictedIds, ...missingIds]); @@ -415,6 +417,13 @@ export function registerRetentionFunctions( reason: "retention score below threshold", }); } + if (orphanScoreIds.length > 0) { + await recordAudit(kv, "delete", "mem::retention-evict", orphanScoreIds, { + resource: "retention_score", + removed: orphanScoreIds.length, + reason: "retention score for a memory that no longer exists", + }); + } logger.info("Retention-based eviction complete", { evicted, diff --git a/test/memory-delete-lock.test.ts b/test/memory-delete-lock.test.ts index db81849e3e..0166b6056d 100644 --- a/test/memory-delete-lock.test.ts +++ b/test/memory-delete-lock.test.ts @@ -10,13 +10,24 @@ vi.mock("../src/config.js", async (importOriginal) => ({ })); const imageReleases: Array<{ path: string; lockHeld: boolean }> = []; -vi.mock("../src/functions/image-refs.js", async (importOriginal) => ({ - ...(await importOriginal()), - decrementImageRef: vi.fn(async (_kv: unknown, _sdk: unknown, path: string) => { +const imageFailures = new Set(); +vi.mock("../src/functions/image-refs.js", async (importOriginal) => { + const actual = await importOriginal(); + const decrementImageRef = vi.fn(async (_kv: unknown, _sdk: unknown, path: string) => { const { isKeyedLockHeld } = await import("../src/state/keyed-mutex.js"); imageReleases.push({ path, lockHeld: isKeyedLockHeld("mem:remember") }); - }), -})); + if (imageFailures.has(path)) throw new Error("image ref write failed"); + }); + const releaseImageRef = vi.fn(async (kv: unknown, sdk: unknown, ownerId: string, path: string) => { + try { + await decrementImageRef(kv, sdk, path); + } catch (err) { + const { logger } = await import("../src/logger.js"); + logger.warn("Image reference release failed after delete", { ownerId, imageRef: path, error: String(err) }); + } + }); + return { ...actual, decrementImageRef, releaseImageRef }; +}); import { registerGovernanceFunction } from "../src/functions/governance.js"; import { registerRelationsFunction } from "../src/functions/relations.js"; @@ -25,6 +36,8 @@ import { registerAutoForgetFunction } from "../src/functions/auto-forget.js"; import { registerRetentionFunctions } from "../src/functions/retention.js"; import { withKeyedLock } from "../src/state/keyed-mutex.js"; import { KV } from "../src/state/schema.js"; +import { getSearchIndex } from "../src/functions/search.js"; +import { memoryToObservation } from "../src/state/memory-utils.js"; import type { Memory, RetentionScore } from "../src/types.js"; type Gate = { scope: string; key: string; reached: () => void; release: Promise }; @@ -298,4 +311,50 @@ describe("retention eviction holds the remember lock", () => { expect(await kv.get(KV.retentionScores, "mem_s")).not.toBeNull(); }); + + it("finishes cleanup and continues the sweep when an image release fails", async () => { + imageFailures.clear(); + imageFailures.add("broken.png"); + const kv = mockKV(); + const sdk = mockSdk(); + registerRetentionFunctions(sdk as never, kv as never); + const broken = makeMemory("mem_img_a", { imageRef: "broken.png" }); + const next = makeMemory("mem_img_b"); + for (const mem of [broken, next]) { + await kv.set(KV.memories, mem.id, mem); + getSearchIndex().add(memoryToObservation(mem), "memory"); + } + await kv.set(KV.retentionScores, "mem_img_a", score("mem_img_a", 0.01)); + await kv.set(KV.retentionScores, "mem_img_b", score("mem_img_b", 0.02)); + + const result = (await sdk.trigger("mem::retention-evict", { threshold: 0.5 })) as { evicted: number }; + imageFailures.clear(); + + expect(result.evicted).toBe(2); + for (const id of ["mem_img_a", "mem_img_b"]) { + expect(await kv.get(KV.memories, id)).toBeNull(); + expect(await kv.get(KV.retentionScores, id)).toBeNull(); + expect(getSearchIndex().has(id)).toBe(false); + } + }); + + it("records an audit entry when it removes orphan scores and evicts nothing", async () => { + const kv = mockKV(); + const sdk = mockSdk(); + registerRetentionFunctions(sdk as never, kv as never); + await kv.set(KV.retentionScores, "mem_orphan", score("mem_orphan", 0.01)); + + const result = (await sdk.trigger("mem::retention-evict", { threshold: 0.5 })) as { evicted: number }; + + expect(result.evicted).toBe(0); + expect(await kv.get(KV.retentionScores, "mem_orphan")).toBeNull(); + const audits = [...kv.store.entries()] + .filter(([scope]) => scope.startsWith("mem:audit")) + .flatMap(([, rows]) => [...rows.values()]) as Array<{ functionId: string; targetIds: string[]; details?: Record }>; + expect(audits).toContainEqual(expect.objectContaining({ + functionId: "mem::retention-evict", + targetIds: ["mem_orphan"], + details: expect.objectContaining({ resource: "retention_score", removed: 1 }), + })); + }); }); From 9f076d3ff11be743d61dba578a33beaaa371e384 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Wed, 11 Nov 2026 12:23:54 +0530 Subject: [PATCH 4/5] fix(evict): release the image of the record deleted under the lock mem::evict read imageRef from the snapshot taken before it waited for mem:remember. If another writer changed imageRef in that window, evict released the old reference and leaked the new one. Use the record that deleteMemoryUnderLock returns, and route every image release in evict through releaseImageRef so a failed release no longer cuts cleanup short. --- src/functions/evict.ts | 26 +++++++++++++------------- test/memory-delete-lock.test.ts | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 13 deletions(-) diff --git a/src/functions/evict.ts b/src/functions/evict.ts index 1ca13aaf2b..7c8d0d5c62 100644 --- a/src/functions/evict.ts +++ b/src/functions/evict.ts @@ -116,7 +116,7 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { sdk.registerFunction("mem::evict", async (data: { dryRun?: boolean }): Promise => { const dryRun = data?.dryRun ?? false; - const { decrementImageRef } = await import("./image-refs.js"); + const { releaseImageRef } = await import("./image-refs.js"); let indexCleaned = false; const removeObservation = ( sessionId: string, @@ -272,8 +272,8 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { continue; } await unindexObservationSession(kv, o.id).catch(() => {}); - if (removed.imageData) await decrementImageRef(kv, sdk, removed.imageData); - if (removed.imageRef && removed.imageRef !== removed.imageData) await decrementImageRef(kv, sdk, removed.imageRef); + if (removed.imageData) await releaseImageRef(kv, sdk, o.id, removed.imageData); + if (removed.imageRef && removed.imageRef !== removed.imageData) await releaseImageRef(kv, sdk, o.id, removed.imageRef); await recordAudit(kv, "delete", "mem::evict", [o.id], { resource: "observation", reason: "low_importance_old_observation", @@ -320,8 +320,8 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { continue; } await unindexObservationSession(kv, o.id).catch(() => {}); - if (removed.imageData) await decrementImageRef(kv, sdk, removed.imageData); - if (removed.imageRef && removed.imageRef !== removed.imageData) await decrementImageRef(kv, sdk, removed.imageRef); + if (removed.imageData) await releaseImageRef(kv, sdk, o.id, removed.imageData); + if (removed.imageRef && removed.imageRef !== removed.imageData) await releaseImageRef(kv, sdk, o.id, removed.imageRef); await recordAudit(kv, "delete", "mem::evict", [o.id], { resource: "observation", reason: "project_observation_cap", @@ -345,8 +345,10 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { stats.expiredMemories++; evictedMemIds.add(mem.id); } else { + let deleted: Memory | null; try { - if (!(await deleteMemoryUnderLock(kv, KV.memories, mem.id))) continue; + deleted = await deleteMemoryUnderLock(kv, KV.memories, mem.id); + if (!deleted) continue; deletedMemIds.add(mem.id); stats.expiredMemories++; evictedMemIds.add(mem.id); @@ -362,9 +364,7 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { getSearchIndex().remove(mem.id); vectorIndexRemove(mem.id); indexCleaned = true; - if (mem.imageRef) { - await decrementImageRef(kv, sdk, mem.imageRef); - } + if (deleted.imageRef) await releaseImageRef(kv, sdk, mem.id, deleted.imageRef); await recordAudit(kv, "delete", "mem::evict", [mem.id], { resource: "memory", reason: "expired_memory", @@ -385,8 +385,10 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { if (dryRun) { stats.nonLatestMemories++; } else { + let deleted: Memory | null; try { - if (!(await deleteMemoryUnderLock(kv, KV.memories, mem.id))) continue; + deleted = await deleteMemoryUnderLock(kv, KV.memories, mem.id); + if (!deleted) continue; deletedMemIds.add(mem.id); stats.nonLatestMemories++; } catch (err) { @@ -401,9 +403,7 @@ export function registerEvictFunction(sdk: IIIClient, kv: StateKV): void { getSearchIndex().remove(mem.id); vectorIndexRemove(mem.id); indexCleaned = true; - if (mem.imageRef) { - await decrementImageRef(kv, sdk, mem.imageRef); - } + if (deleted.imageRef) await releaseImageRef(kv, sdk, mem.id, deleted.imageRef); await recordAudit(kv, "delete", "mem::evict", [mem.id], { resource: "memory", reason: "old_non_latest_memory", diff --git a/test/memory-delete-lock.test.ts b/test/memory-delete-lock.test.ts index 0166b6056d..66fd6d6cdc 100644 --- a/test/memory-delete-lock.test.ts +++ b/test/memory-delete-lock.test.ts @@ -234,6 +234,34 @@ describe("memory delete paths hold the remember lock", () => { expect(await kv.get(KV.memories, "mem_img")).toBeNull(); expect(imageReleases).toEqual([{ path: "new.png", lockHeld: false }]); }); + + it("evict releases the image of the record it deleted, not the pre-lock snapshot", async () => { + imageReleases.length = 0; + const kv = mockKV(); + const sdk = mockSdk(); + registerEvictFunction(sdk as never, kv as never); + await kv.set(KV.memories, "mem_ev", makeMemory("mem_ev", { forgetAfter: "2020-01-01T00:00:00Z", imageRef: "old.png" })); + + let release!: () => void; + let reached!: () => void; + const reachedPromise = new Promise((resolve) => { reached = resolve; }); + const releasePromise = new Promise((resolve) => { release = resolve; }); + const holder = withKeyedLock("mem:remember", async () => { + reached(); + await releasePromise; + const current = await kv.get(KV.memories, "mem_ev"); + await kv.set(KV.memories, "mem_ev", { ...current!, imageRef: "new.png" }); + }); + await reachedPromise; + const run = sdk.trigger("mem::evict", {}); + await new Promise((resolve) => setTimeout(resolve, 10)); + release(); + await holder; + await run; + + expect(await kv.get(KV.memories, "mem_ev")).toBeNull(); + expect(imageReleases).toEqual([{ path: "new.png", lockHeld: false }]); + }); }); function score(memoryId: string, value: number): RetentionScore { From 35447ed58618c723b1267af44a85368a2b738e60 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Thu, 12 Nov 2026 17:24:36 +0530 Subject: [PATCH 5/5] test(memory): cover the real releaseImageRef failure path The delete-lock suite mocks releaseImageRef, so a regression in its catch path would leave the suite green. A separate test now runs the real helper against a store whose write fails and checks that it logs the failure and does not throw, plus the normal decrement. Signed-off-by: Rohit Ghumare --- test/image-ref-release.test.ts | 50 ++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 test/image-ref-release.test.ts diff --git a/test/image-ref-release.test.ts b/test/image-ref-release.test.ts new file mode 100644 index 0000000000..7f9784231b --- /dev/null +++ b/test/image-ref-release.test.ts @@ -0,0 +1,50 @@ +import { describe, it, expect, vi, beforeEach } from "vitest"; + +const { warn } = vi.hoisted(() => ({ warn: vi.fn() })); +vi.mock("../src/logger.js", () => ({ + logger: { info: vi.fn(), warn, error: vi.fn() }, +})); + +import { releaseImageRef } from "../src/functions/image-refs.js"; +import { KV } from "../src/state/schema.js"; + +function kvWithFailingWrite(count: number) { + return { + get: async (scope: string) => (scope === KV.imageRefs ? count : null), + set: async () => { + throw new Error("image ref write failed"); + }, + delete: async () => {}, + list: async () => [], + }; +} + +describe("releaseImageRef", () => { + beforeEach(() => warn.mockClear()); + + it("logs a failed image ref write and does not throw", async () => { + const sdk = { trigger: vi.fn() }; + await expect(releaseImageRef(kvWithFailingWrite(2) as never, sdk as never, "mem_1", "/tmp/img-a.png")).resolves.toBeUndefined(); + expect(warn).toHaveBeenCalledWith("Image reference release failed after delete", { + ownerId: "mem_1", + imageRef: "/tmp/img-a.png", + error: "image ref write failed", + }); + }); + + it("decrements the count when the write succeeds", async () => { + const writes: Array<[string, string, unknown]> = []; + const kv = { + get: async () => 3, + set: async (scope: string, key: string, value: unknown) => { + writes.push([scope, key, value]); + return value; + }, + delete: async () => {}, + list: async () => [], + }; + await releaseImageRef(kv as never, { trigger: vi.fn() } as never, "mem_2", "/tmp/img-b.png"); + expect(writes).toEqual([[KV.imageRefs, "/tmp/img-b.png", 2]]); + expect(warn).not.toHaveBeenCalled(); + }); +});