From 6c96ee6dfc3b8ea809d92a21f0a5e437d2a75a73 Mon Sep 17 00:00:00 2001 From: aryaMehta26 Date: Wed, 27 May 2026 05:40:30 -0700 Subject: [PATCH] test(client-typescript): fix disconnect timeout guard swallowing errors The previous implementation used resolve() inside setTimeout(), which silently passed the test if client.disconnect() took longer than the timeout. Switched it to reject() with an error message so tests properly fail on timeout. --- packages/client-typescript/tests/RocketRideClient.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/client-typescript/tests/RocketRideClient.test.ts b/packages/client-typescript/tests/RocketRideClient.test.ts index 0a59d5f1d..2306fa81d 100644 --- a/packages/client-typescript/tests/RocketRideClient.test.ts +++ b/packages/client-typescript/tests/RocketRideClient.test.ts @@ -71,7 +71,7 @@ describe('RocketRideClient Integration Tests', () => { afterEach(async () => { if (client.isConnected()) { // Use a bounded timeout so teardown never hangs the suite - await Promise.race([client.disconnect(), new Promise((resolve) => setTimeout(resolve, 10000))]); + await Promise.race([client.disconnect(), new Promise((_, reject) => setTimeout(() => reject(new Error('disconnect timeout exceeded')), 10000))]); } }); @@ -1669,7 +1669,7 @@ Line 3: random data ${Math.random().toString(36).substring(2)}`; } }) ), - new Promise((resolve) => setTimeout(resolve, 15000)), + new Promise((_, reject) => setTimeout(() => reject(new Error('pipeline cleanup timeout exceeded')), 15000)), ]); pipelineTokens = []; }); @@ -2042,7 +2042,7 @@ Line 3: random data ${Math.random().toString(36).substring(2)}`; expect(uniqueTexts.size).toBe(SENDS_PER_CLIENT * 2); } finally { if (clientB.isConnected()) { - await Promise.race([clientB.disconnect(), new Promise((resolve) => setTimeout(resolve, 10000))]); + await Promise.race([clientB.disconnect(), new Promise((_, reject) => setTimeout(() => reject(new Error('disconnect timeout exceeded')), 10000))]); } } },