Extract *.zip/*.tar.gz issues

[hkettler]

Hi,

1. "Download URL for binary archive" does not work:

   Unpacking http://server.net/releases/myos1.0.tgz to /var/lib/jenkins/tools/org.jenkinsci.plugins.chroot.tools.ChrootToolset/myos on Jenkins
   FATAL: Failed to copy /var/lib/jenkins/tools/myos to /var/lib/jenkins/workspace/chroot_test2/myos/myos
   [...]
   Caused by: java.io.FileNotFoundException: /var/lib/jenkins/tools/myos (Is a directory)

   Either the plugin wants the tool tarball as an argument (it's a file), or the copy method is not sufficient (has to be recursive then).

2. If giving a 'Subdirectory of extracted archive', the plugin behaves strangely: It will always unpack the tarball given in the subdir, even though the tarball from the url was successfully downloaded (in case it was newer/differs). I 've tested with a newer tarball at the url including more packages than the local one from the subdir. The packages are not available in the build.

3. Help text of 'Subdirectory of extracted archive' is misleading. Clearly, the plugin is searching for the tarball, not the "unpacked archive". Also not mentioned: the required md5 file.

Regards, Holger

[konsumate]

@rmohr I noticed this issue too, do you mind throwing a look into this one? Thanks

[thellef]

I looked briefly at this some weeks ago (might also become relevant for me, later). As far as I could determine, only the "Install automatically" option is intended to work. The other options show up because they're generic "tool installation" methods, but they install the tools in a way that this plug-in does not expect, so they don't work.
They could work if either the plug-in checks for tool installation in two different ways (it cannot on build-time lookup how it was installed, so has to determine by looking in the filesystem), OR the plug-in and the installation method should be changed to match how the others work.
By the way: The plug-in (or rather pbuilder) requires a tarball and an md5 file to run. So the contents of the zip file to be extracted should be a tarball and an md5 file. But it still won't work right now.

[konsumate]

@KodeKarl is there an alternative to "installIfNecessary" in jenkins to pull a file from an url if needed and to not extract it?

[thellef]

@CoreCache I'm not all that much an expert into it; just enough to believe what I wrote :-)
Anyway, perhaps the "Run Shell Command" installer could help you? You could enter a command that would pull the file into the expected place?
(Mind you, I'm not sure the plugin would be able to handle it - but please try it out and post results here)

[konsumate]

@KodeKarl I've also implemented a "download tarball from URL if no tarball exists AND a tarball_url is given, else behave like before" Feature, where tarball_url is a new String field per chroot installation - this should get rid of a pre-step for the plugin.

[thellef]

OK. I was looking at the installer code yesterday evening, but got too tired ...
I think that I personally would prefer a "proper" installer to do that job, rather than duplicate some download code in the builder class.
Anyway, make a separate pull-request for it and let's see how it works?

[rmohr]

As @KodeKarl said, at the moment the plugin does not allow the use of pregenerated chroot images. Only the "install if necessary" way is supported at the moment. I will try to look into this, but I can't promise very mucht, my time is currently very limited.

[konsumate]

@rmohr See my own current compatible workaround: konsumate@5a31eb5

[rmohr]

@CoreCache Are you still interested in merging this? That looks pretty nice. Could you create a pull request?

[konsumate]

@rmohr Since I switched jobs, I no longer have a jenkins setup at hand - feel free to merge it straight away - it did work back then, no clue how it is going to perform 1 year later

[rmohr]

@CoreCache OK, will do that. Thanks for your work on the plugin 👍