Configuring shell history in home.sessionVariables?

[Roverp1]

Hi! I wanted to ask question about source code.
I've noticed you configure history (with this weird setopt syntax) in home.sessionVariables. I'm curious why was it chosen over configuring history in shell.nix?
Does it make this configuration shell agnostic 🤔

       # History configuration // explicit to not nuke history
      HISTFILE = "\${HISTFILE:-\$HOME/.zsh_history}";
      HISTSIZE = "10000";
      SAVEHIST = "10000";
      setopt_EXTENDED_HISTORY = "true";
      setopt_INC_APPEND_HISTORY = "true";
      setopt_SHARE_HISTORY = "true";
      setopt_HIST_EXPIRE_DUPS_FIRST = "true";
      setopt_HIST_IGNORE_DUPS = "true";
      setopt_HIST_IGNORE_ALL_DUPS = "true";

code from xdg.nix

[richen604]

because hyde uses these globally as env variables, but i agree it makes more sense to have them in shell

[Roverp1]

Thank you for the answer! It makes sense

I have a few more similar questions if you don't mind answering them. Particularly about Hyde files copied into ~/.config/zsh/.

In shell.nix, I can see that you are copying a few files into ~/.config/zsh/:

    home.file = lib.mkMerge [
      (lib.mkIf cfg.zsh.enable {
        # Zsh configs
        ".zshenv".source = "${pkgs.hydenix.hyde}/Configs/.zshenv";
        ".config/zsh/completions/hyde-shell.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/completions/hyde-shell.zsh";
        ".config/zsh/.p10k.zsh" = {
          source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/.p10k.zsh";
          enable = cfg.p10k.enable;
        };
        ".config/zsh/completions/fzf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/completions/fzf.zsh";
        ".config/zsh/completions/hydectl.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/completions/hydectl.zsh";
        ".config/zsh/functions/bat.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/bat.zsh";
        ".config/zsh/functions/bind_M_n_history.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/bind_M_n_history.zsh";
        ".config/zsh/functions/duf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/duf.zsh";
        ".config/zsh/functions/error-handlers.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/error-handlers.zsh";
        ".config/zsh/functions/eza.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/eza.zsh";
        ".config/zsh/functions/fzf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/fzf.zsh";
        ".config/zsh/functions/kb_help.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/kb_help.zsh";


        # We are not including any of these configurations as they are part of the existing zsh options
        # ".config/zsh/.zshenv".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/.zshenv";
    ...
      })

but i cant find anywhere (not in home-manager configuration, not in bulided files inside ~/.config/zsh/) where you are sourcing any of the files from completions/ or functions/ directories. And it looks like I dont have their added functionality in my shell:

Are those files (inside ~/.config/zsh/completions/ and ~/.config/zsh/functions) supposed to be optional?

[richen604]

yeah good point ill confirm if those are being sourced correctly chances are they are not. PR's are welcome

[Roverp1]

Good, I can do a PR in near time. But your confirmation is welcome.

And I also noticed that you define similar functions from ".config/zsh/functions/fzf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/fzf.zsh" directly in programs.zsh.initContent (all functions from fzf.zsh except for _fuzzy_search_cmd_history) .

diff of functions/fzf.zsh (left side) and ~/.config/zsh/.zshrc (right side)

PR plan

1. Delete functions/fzf.zsh
2. source all files from completions/ and functions in zsh.initContent. e.g.:

# Source all .zsh files in ~/.config/zsh/functions/
if [[ -d ~/.config/zsh/functions ]]; then
    for file in ~/.config/zsh/functions/*.zsh; do
        [[ -f "$file" ]] && source "$file"
    done
fi

# Source all .zsh files in ~/.config/zsh/completions/
if [[ -d ~/.config/zsh/completions ]]; then
    for file in ~/.config/zsh/completions/*.zsh; do
        [[ -f "$file" ]] && source "$file"
    done
fi

3. Create fzf.nix module with zshIntegration like this - which automatically adds fuzzy history search
4. Dynamicly add fzf functions and aliases with lib.optionalString to zsh.initContent if fzf.nix module is enabled

Please tell me if this solution looks good to you, and I can implement it.

Also I've noticed a few more strange things with shell module, like staship env variables getting sourced even tho starship is disabled:

it was causing strange prints when i would disable shell module and enable my custom zsh configuration, but probably not a big issue

[richen604]

we dont need to break these out into modules, with hyde they are all enabled by default

as for envs hyde loads these globally iirc

[Roverp1]

we dont need to break these out into modules, with hyde they are all enabled by default

Ok, then I can just source fzf --zsh from zsh.initContent