ci: add clippy core guard and clear clippy debt in core crates

Author: rexleimo

.github/workflows/ci.yml

@@ -196,6 +196,23 @@ jobs:
       - name: Check (workspace, locked)
         run: cargo check --workspace --locked
 
+  clippy-core-fast:
+    name: clippy core crates (fast)
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Rust cache
+        uses: Swatinem/rust-cache@v2
+
+      - name: Clippy (core crates, all targets)
+        run: cargo clippy -p rexos-tools -p rexos-llm -p rexos-kernel --all-targets --locked -- -D warnings
+
   docs:
     name: docs build
     runs-on: ubuntu-latest

crates/rexos-kernel/src/config.rs

@@ -159,20 +159,12 @@ impl Default for SkillsConfig {
     }
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
 #[serde(default)]
 struct SkillsConfigWrapper {
     skills: SkillsConfig,
 }
 
-impl Default for SkillsConfigWrapper {
-    fn default() -> Self {
-        Self {
-            skills: SkillsConfig::default(),
-        }
-    }
-}
-
 impl RexosConfig {
     pub fn ensure_default(paths: &RexosPaths) -> anyhow::Result<()> {
         storage::ensure_default_config(paths)

crates/rexos-kernel/src/security.rs

@@ -59,22 +59,11 @@ pub struct EgressConfig {
     pub rules: Vec<EgressRule>,
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Default)]
 #[serde(default)]
 pub struct EgressRule {
     pub tool: String,
     pub host: String,
     pub path_prefix: String,
     pub methods: Vec<String>,
 }
-
-impl Default for EgressRule {
-    fn default() -> Self {
-        Self {
-            tool: String::new(),
-            host: String::new(),
-            path_prefix: String::new(),
-            methods: Vec::new(),
-        }
-    }
-}

crates/rexos-llm/src/anthropic/driver.rs

@@ -32,7 +32,7 @@ impl AnthropicDriver {
 }
 
 impl LlmDriver for AnthropicDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move {
             let anthropic_req = build_request(req)?;
 

crates/rexos-llm/src/bedrock/driver.rs

@@ -78,7 +78,7 @@ impl BedrockDriver {
 }
 
 impl LlmDriver for BedrockDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move {
             let model_id = self.model_id(&req.model);
             if model_id.is_empty() {

crates/rexos-llm/src/dashscope/driver.rs

@@ -31,7 +31,7 @@ impl DashscopeDriver {
 }
 
 impl LlmDriver for DashscopeDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move {
             let dash_req = DashscopeRequest {
                 model: req.model,

crates/rexos-llm/src/driver.rs

@@ -9,7 +9,7 @@ use crate::openai_compat::{ChatCompletionRequest, ChatMessage, OpenAiCompatibleC
 pub type ChatFuture<'a> = Pin<Box<dyn Future<Output = anyhow::Result<ChatMessage>> + Send + 'a>>;
 
 pub trait LlmDriver: Send + Sync {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a>;
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_>;
 }
 
 #[derive(Clone)]
@@ -26,7 +26,7 @@ impl OpenAiCompatDriver {
 }
 
 impl LlmDriver for OpenAiCompatDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move { self.client.chat_completions(req).await })
     }
 }
@@ -45,7 +45,7 @@ impl UnimplementedDriver {
 }
 
 impl LlmDriver for UnimplementedDriver {
-    fn chat<'a>(&'a self, _req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, _req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move { bail!("provider not implemented: {}", self.provider) })
     }
 }

crates/rexos-llm/src/gemini/driver.rs

@@ -32,7 +32,7 @@ impl GeminiDriver {
 }
 
 impl LlmDriver for GeminiDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move {
             let gemini_req = build_request(&req)?;
 

crates/rexos-llm/src/minimax/driver.rs

@@ -31,7 +31,7 @@ impl MiniMaxDriver {
 }
 
 impl LlmDriver for MiniMaxDriver {
-    fn chat<'a>(&'a self, req: ChatCompletionRequest) -> ChatFuture<'a> {
+    fn chat(&self, req: ChatCompletionRequest) -> ChatFuture<'_> {
         Box::pin(async move {
             let tool_choice = if req.tools.is_empty() {
                 "none".to_string()

crates/rexos-llm/src/registry/tests.rs

@@ -30,7 +30,7 @@ fn secret_resolver_reads_provider_key_from_env() {
         security: Default::default(),
     };
 
-    let resolver = SecretResolver::default();
+    let resolver = SecretResolver;
     assert_eq!(
         resolver.resolve_provider_api_key(&cfg, "anthropic"),
         Some("test-secret".to_string())
@@ -43,7 +43,7 @@ fn secret_resolver_reads_provider_key_from_env() {
 fn secret_resolver_returns_none_for_blank_env_name() {
     use rexos_kernel::secrets::SecretResolver;
 
-    let resolver = SecretResolver::default();
+    let resolver = SecretResolver;
     assert_eq!(resolver.resolve_env(""), None);
 }