Sample app: adopt the pending-requests indicator and go multi-account
Labels: enhancement
Goal
Make the sample app the reference implementation of the new split: a small indicator
placed by the developer, and a dedicated screen owned by the app.
Work
- Put
NPendingRequestsIndicator in the AppBar, with onTap pushing
PendingRequestsPage.
- Make
packages/sample-app/lib/pending_requests_page.dart multi-account. It
currently reads ndk.accounts.getLoggedAccount() (line 286) and subscribes to that
one signer (line 302), so it has the same blind spot as the widget being replaced.
It should consume the aggregated stream, group by account, and route
cancelRequest (line 339) to the right signer.
Why this is not cosmetic
This is the acceptance test for the aggregated stream API. If grouping by account and
routing cancels is awkward to write here, the API is wrong and should be fixed before
it ships, not worked around in the sample.
Depends on
The indicator issue, and through it the aggregated stream issue.
Sample app: adopt the pending-requests indicator and go multi-account
Labels:
enhancementGoal
Make the sample app the reference implementation of the new split: a small indicator
placed by the developer, and a dedicated screen owned by the app.
Work
NPendingRequestsIndicatorin theAppBar, withonTappushingPendingRequestsPage.packages/sample-app/lib/pending_requests_page.dartmulti-account. Itcurrently reads
ndk.accounts.getLoggedAccount()(line 286) and subscribes to thatone signer (line 302), so it has the same blind spot as the widget being replaced.
It should consume the aggregated stream, group by account, and route
cancelRequest(line 339) to the right signer.Why this is not cosmetic
This is the acceptance test for the aggregated stream API. If grouping by account and
routing cancels is awkward to write here, the API is wrong and should be fixed before
it ships, not worked around in the sample.
Depends on
The indicator issue, and through it the aggregated stream issue.