From aa636aaecf74c2ebbe13f9aef0dfa83d2cfb8984 Mon Sep 17 00:00:00 2001 From: Christopher <131207452+PetrefiedThunder@users.noreply.github.com> Date: Sat, 24 Oct 2026 20:42:23 -0700 Subject: [PATCH] fix(ci): Engine Review Pass follow-ups from #3577 review threads - rerun on deleted issue comments so a removed marker updates the status - order comment markers by updated_at so an edit takes effect when made - accept uppercase hex in the marker SHA (compared case-insensitively) --- .github/workflows/engine-review-pass.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/engine-review-pass.yml b/.github/workflows/engine-review-pass.yml index e84025c1f..485293ce1 100644 --- a/.github/workflows/engine-review-pass.yml +++ b/.github/workflows/engine-review-pass.yml @@ -8,7 +8,7 @@ on: pull_request_review: types: [submitted, dismissed] issue_comment: - types: [created, edited] + types: [created, edited, deleted] # Review bursts must not cancel in-progress runs. concurrency: @@ -140,7 +140,8 @@ jobs: const normalizedComments = comments.map((c) => ({ id: c.id, body: c.body, - submitted_at: c.created_at, + // Edits take effect at their edit time, so use updated_at. + submitted_at: c.updated_at || c.created_at, author_association: c.author_association, user: c.user, state: 'COMMENTED', @@ -172,7 +173,7 @@ jobs: }); // The marker must be alone on its own line. - const markerRegex = /^REVIEW: (PASS|BLOCKED|FAIL) ([A-Za-z0-9._-]+) ([0-9a-f]{40})\s*$/; + const markerRegex = /^REVIEW: (PASS|BLOCKED|FAIL) ([A-Za-z0-9._-]+) ([0-9A-Fa-f]{40})\s*$/; const headShaLower = headSha.toLowerCase(); const authorEngineLower = authorEngine.toLowerCase();