Update node-sdk example tests for flag overrides API

Author: roncohen

packages/node-sdk/examples/express/app.test.ts

@@ -1,14 +1,32 @@
 import request from "supertest";
 import app, { todos } from "./app";
-import { beforeEach, describe, it, expect, beforeAll } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
 
 import reflag from "./reflag";
 
+function flag(name: string, enabled: boolean): void {
+  let remove: (() => void) | undefined;
+
+  beforeEach(() => {
+    remove = reflag.pushFlagOverrides({ [name]: enabled });
+  });
+
+  afterEach(() => {
+    remove?.();
+    remove = undefined;
+  });
+}
+
 beforeAll(async () => await reflag.initialize());
+
 beforeEach(() => {
-  reflag.featureOverrides = {
+  reflag.setFlagOverrides({
     "show-todos": true,
-  };
+  });
+});
+
+afterEach(() => {
+  reflag.clearFlagOverrides();
 });
 
 describe("API Tests", () => {
@@ -24,12 +42,13 @@ describe("API Tests", () => {
     expect(response.body).toEqual({ todos });
   });
 
-  it("should return no todos when list is disabled", async () => {
-    reflag.featureOverrides = () => ({
-      "show-todos": false,
+  describe("with show-todos temporarily disabled", () => {
+    flag("show-todos", false);
+
+    it("should return no todos", async () => {
+      const response = await request(app).get("/todos");
+      expect(response.status).toBe(200);
+      expect(response.body).toEqual({ todos: [] });
     });
-    const response = await request(app).get("/todos");
-    expect(response.status).toBe(200);
-    expect(response.body).toEqual({ todos: [] });
   });
 });

packages/node-sdk/examples/express/app.ts

@@ -1,6 +1,6 @@
 import reflag from "./reflag";
 import express from "express";
-import { BoundReflagClient } from "../src";
+import type { BoundReflagClient } from "../../src";
 
 // Augment the Express types to include the `reflagUser` property on the `res.locals` object
 // This will allow us to access the ReflagClient instance in our route handlers

packages/node-sdk/examples/express/bucket.ts

@@ -1,11 +1,11 @@
-import { ReflagClient, Context, FlagOverrides } from "../../";
+import { ReflagClient, Context, FlagOverrides } from "../../src";
 
 type CreateConfigPayload = {
   minimumLength: number;
 };
 
 // Extending the Flags interface to define the available features
-declare module "../../types" {
+declare module "../../src/types" {
   interface Flags {
     "show-todos": boolean;
     "create-todos": {
@@ -18,7 +18,7 @@ declare module "../../types" {
   }
 }
 
-let featureOverrides = (_: Context): FlagOverrides => {
+const flagOverrides = (_: Context): FlagOverrides => {
   return {
     "create-todos": {
       isEnabled: true,
@@ -39,5 +39,5 @@ let featureOverrides = (_: Context): FlagOverrides => {
 export default new ReflagClient({
   // Optional: Set a logger to log debug information, errors, etc.
   logger: console,
-  featureOverrides, // Optional: Set feature overrides
+  flagOverrides, // Optional: Set flag overrides
 });

packages/node-sdk/examples/express/reflag.ts

@@ -0,0 +1 @@
+export { default } from "./bucket";