Bug: Error while parsing

[phil-flip]

ERROR: TypeError: Cannot read properties of undefined (reading 'attribs')
    at ParseSubmission (/usr/src/app/node_modules/furaffinity-api/dist/Parser.js:260:70)
    at /usr/src/app/node_modules/furaffinity-api/dist/index.js:80:45
    at Generator.next (<anonymous>)
    at fulfilled (/usr/src/app/node_modules/furaffinity-api/dist/index.js:19:58)

I'm still investigating which line is causing issues here, I will post an update below, but didn't want to keep this bug a secret.

[phil-flip]

255 |     const content = main.find(".submission-content");
256 |     const stats = sidebar.find(".stats-container");
257 |     const info = sidebar.find(".info");
258 |     const tags = sidebar.find(".tags-row .tags a");
259 |     // buttons
260 |     let downloadUrl = `http:${sidebar.find(".buttons .download a")[0].attribs.href}`;
                                                                         ^
TypeError: undefined is not an object (evaluating 'sidebar.find(".buttons .download a")[0].attribs')
      at ParseSubmission (/home/phil/Documents/github/fur-importer_all_artists/node_modules/furaffinity-api/dist/Parser.js:260:68)
      at fulfilled (/home/phil/Documents/github/fur-importer_all_artists/node_modules/furaffinity-api/dist/index.js:19:58)

Bun v1.3.13-canary.1+890ef5a3b (Linux x64)

[onegen-dev]

FurAffinity just changed the design of submissions. The new design change impacts the whole ‘Modern’ template, including ‘Retro Dark’. (As this tool works by scraping the website, the elements aren’t where the scraper script expects them to be and thus errors out.)

On the furaffinity-api-powered script I use, which did work few weeks ago, I am observing the same error (openSUSE Leap 16.0, x86_64 Linux, Node.js v22.22.0):

  Failed to fave 49985681: TypeError: Cannot read properties of undefined (reading 'attribs')
    at ParseSubmission (/home/onegen/devel/experiments/fafav/ctrl/node_modules/furaffinity-api/dist/Parser.js:260:70)
    at /home/onegen/devel/experiments/fafav/ctrl/node_modules/furaffinity-api/dist/index.js:80:45
    at Generator.next (<anonymous>)
    at fulfilled (/home/onegen/devel/experiments/fafav/ctrl/node_modules/furaffinity-api/dist/index.js:19:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

As with similar scraper-powered tools, a redesign that cannot be themed back causes a breakage and it will probably take some time to fix in the library. 😕 I wasn’t able to find a rollback so if anyone knows if I can somehow do that, please do tell.

The main change are the buttons and the sidebar, explaining the sidebar.find(".buttons .download a")[0].attribs error. The new sidebar looks like this:

On code level, the .download class has been removed. The buttons do not seem to have a straightforward way to just tell which is which:

<a class="button standard mobile-fix" href="//d.furaffinity.net/art/…">Download</a>

The whole button section:

<div class="submission-controls-upper">
    <a class="button standard mobile-fix" href="/unfav/…/?key=…">-Fav</a>
    <a class="button standard mobile-fix" href="/newpm/…">Note</a>
    <a class="button standard mobile-fix" href="//d.furaffinity.net/art/…">Download</a>
    <a class="button standard mobile-fix nuke remove_nuke" href="/controls/troubletickets/…">Report</a>
</div>

I guess the fix would have to have the buttons be told apart by their index (0 = fav/unfav, 1 = note, 2 = download & 3 = report) rather than by classes?

[phil-flip]

So I'm going through all of them atm. It seems that quite a lot of parsing seems to have broken with some recent update.